3.8 compat #24
Open
3.8 compat #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The UI is def borked in 3.8. https://www.dropbox.com/s/t4u6hvg7tu7mb7r/Screenshot%202014-03-25%2019.12.16.png Would be great if this fix could get committed and pushed out! |
|
Agreed. |
|
Would love this fixed too 👍 :) |
|
+1 |
2 tasks
|
I've created a fix to use the newer version of the media modal and some other fixes: |
|
I've have recently been granted commit access to maintain this plugin on WordPress.org I have recently released version 0.9 which uses the newer Media Modal. I will be continuing development in this GitHub repo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made some updates to make the UI work better in 3.8. Without these edits, the modal looks broken. Props to Herbert on the WordPress.org forums for figuring out that fix: http://wordpress.org/support/topic/searchbox-missing
I also made the thumbnails retina compatible.
Additionally, I changed the big question mark image to "Set Featured Image" so the UI matches the WP post featured image UI. I also removed the +/- buttons and changed that to just "Remove Featured Image"
I also fixed two bugs where if you associated an image and closed the modal, then opened the modal again, it wouldn't show the "Remove association" link for that image. Similarly if you removed an association in the modal, and then closed and reopened the modal, it wouldn't show the "Associate.." button.
If you want me to break this up into smaller pull requests, let me know. :)