Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency version updated, docker compose command updated in workflow yml #22

Merged
merged 4 commits into from
Aug 7, 2024
Merged

Dependency version updated, docker compose command updated in workflow yml #22

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a8f4275
updated dependency version in pom.xml and updated docker compose comm…
mfaisalkhatri Aug 7, 2024
f329251
updated maven.yml to use docker compose instead of docker-compose com…
mfaisalkhatri Aug 7, 2024
78c5f21
updated to use ubuntu-22.04 as runner in GitHub Actions
mfaisalkhatri Aug 7, 2024
24d9ac9
reverted back to use ubuntu-latest
mfaisalkhatri Aug 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/maven.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ jobs:
cache: maven

- name: Start restful booker service
run: docker-compose -f ./docker-compose-restfulbooker.yml up -d
run: docker compose -f ./docker-compose-restfulbooker.yml up -d

- name: Build Project
run: mvn clean install -DskipTests
Expand All @@ -44,7 +44,7 @@ jobs:
run: mvn clean test

- name: Stop restful booker service
run: docker-compose -f ./docker-compose-restfulbooker.yml down --remove-orphans
run: docker compose -f ./docker-compose-restfulbooker.yml down --remove-orphans

- name: Test Reporter
uses: dorny/[email protected]
Expand Down
4 changes: 2 additions & 2 deletions docker-compose-restfulbooker.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# To execute this docker-compose yml file use `docker-compose -f docker-compose-restfulbooker.yml up -d`
# To execute this docker-compose yml file use `docker compose -f docker-compose-restfulbooker.yml up -d`
# Add the `-d` flag at the end for detached execution
# To stop the execution, hit Ctrl+C, and then `docker-compose -f docker-compose-restfulbooker.yml down`
# To stop the execution, hit Ctrl+C, and then `docker compose -f docker-compose-restfulbooker.yml down`
version: "3"
services:
restful-booker:
Expand Down
16 changes: 8 additions & 8 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,17 +12,17 @@

<properties>
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
<playwright-version>1.41.2</playwright-version>
<testng-version>7.9.0</testng-version>
<playwright-version>1.45.1</playwright-version>
<testng-version>7.10.2</testng-version>
<hamcrest-all-version>1.3</hamcrest-all-version>
<json-simple-version>1.1.1</json-simple-version>
<lombok-version>1.18.28</lombok-version>
<datafaker-version>2.1.0</datafaker-version>
<org-json-verion>20230618</org-json-verion>
<maven-compiler-plugin-version>3.11.0</maven-compiler-plugin-version>
<maven-surefire-plugin-version>3.1.0</maven-surefire-plugin-version>
<lombok-version>1.18.34</lombok-version>
<datafaker-version>2.3.1</datafaker-version>
<org-json-verion>20240303</org-json-verion>
<maven-compiler-plugin-version>3.13.0</maven-compiler-plugin-version>
<maven-surefire-plugin-version>3.3.1</maven-surefire-plugin-version>
<java-release-version>17</java-release-version>
<maven-enforcer-version>3.4.0</maven-enforcer-version>
<maven-enforcer-version>3.5.0</maven-enforcer-version>
<suite-xml>test-suite/testng.xml</suite-xml>
</properties>
<dependencies>
Expand Down
Loading