Skip to content

Commit

Permalink
fix: remove click_completion
Browse files Browse the repository at this point in the history
Shell completion is now supported by click itself and the extra package is dead.

click-contrib/click-completion#37
click-contrib/click-completion#41

It is still not trivial to use because it needs to be enabled for the shell.
And maybe is and always was impossible for these example .py files because they are not real commands anyway.

https://click.palletsprojects.com/en/8.1.x/shell-completion/
  • Loading branch information
tilsche committed Jun 1, 2023
1 parent 62f3acc commit 495b293
Show file tree
Hide file tree
Showing 7 changed files with 0 additions and 18 deletions.
2 changes: 0 additions & 2 deletions metricq_tools/check.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
import math

import click
import click_completion
import click_log
import metricq

Expand All @@ -12,7 +11,6 @@

logger = get_root_logger()

click_completion.init()


async def check_for_non_finite(client):
Expand Down
3 changes: 0 additions & 3 deletions metricq_tools/discover.py
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,6 @@
import aio_pika
import async_timeout
import click
import click_completion
import click_log
import humanize
import metricq
Expand All @@ -60,8 +59,6 @@

logger = get_root_logger()

click_completion.init()


class IgnoredEvent(CommandLineChoice, Enum):
ErrorResponses = enum_auto()
Expand Down
3 changes: 0 additions & 3 deletions metricq_tools/inspect.py
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@

import aio_pika
import click
import click_completion
import click_log
import metricq
import numpy as np
Expand All @@ -45,8 +44,6 @@

logger = get_root_logger()

click_completion.init()


class InspectSink(metricq.Sink):
def __init__(
Expand Down
3 changes: 0 additions & 3 deletions metricq_tools/send.py
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@
# SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.

import click
import click_completion
import click_log
from metricq import Source, Timestamp
from metricq.types import Metric
Expand All @@ -40,8 +39,6 @@

logger = get_root_logger()

click_completion.init()


class MetricQSend(Source):
def __init__(self, metric, timestamp, value, *args, **kwargs):
Expand Down
3 changes: 0 additions & 3 deletions metricq_tools/spy.py
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@

import aio_pika
import click
import click_completion
import click_log
import metricq
from metricq.types import Metric
Expand All @@ -44,8 +43,6 @@

logger = get_root_logger()

click_completion.init()

Database = str


Expand Down
3 changes: 0 additions & 3 deletions metricq_tools/summary.py
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@
from sys import exit

import click
import click_completion
import click_log
import metricq
import numpy as np
Expand All @@ -47,8 +46,6 @@

logger = get_root_logger()

click_completion.init()


class Summary:
def __init__(
Expand Down
1 change: 0 additions & 1 deletion setup.cfg
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ install_requires =
metricq ~= 4.0
click
click-log
click-completion
async-timeout~=3.0
humanize~=2.5
python-dateutil~=2.8
Expand Down

0 comments on commit 495b293

Please sign in to comment.