Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove auto-deletion toggle #46

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix: remove auto-deletion toggle
It seems highly reliable, so let's remove this.

Fixes #20
bmario committed Mar 6, 2023

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
commit 1d732959afd17b2ef3706bc259abcaf7302e496a
21 changes: 6 additions & 15 deletions metricq_manager/manager.py
Original file line number Diff line number Diff line change
@@ -337,21 +337,12 @@ async def handle_unsubscribe(self, from_token, **body):
}

@rpc_handler("release", "sink.release")
async def handle_release(self, from_token, **body):
queue_name = body["dataQueue"]
if self._subscription_autodelete:
logger.debug(
"Ignoring request to release data queue of {!r} (queue {} is auto-delete)",
queue_name,
from_token,
)
else:
if not (queue_name.startswith(from_token) and queue_name.endswith("-data")):
raise ValueError("Invalid subscription queue name")

logger.debug("Releasing data queue {} of {!r}", queue_name, from_token)

await self.queue_manager.sink_delete_data_queue(queue_name)
async def handle_release(self, from_token, dataQueue, **body):
logger.debug(
"Ignoring request to release data queue of {!r} (queue {} is auto-delete)",
dataQueue,
from_token,
)

@rpc_handler("sink.register")
async def handle_sink_register(self, from_token, **body):