Logging in lazy sequences may interfere with output of Content-Type: application/edn #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
opqdonut
reviewed
Jan 8, 2025
| (pr-str data) | ||
| ^String charset)) | ||
| (let [w (new java.io.StringWriter)] | ||
| (pr-to-writer w data) |
There was a problem hiding this comment.
you're only using arity 1 of pr-to-writer here, so you could just call (print-method data w) directly, right?
There was a problem hiding this comment.
of course, you are right! print-method is the way to go and it simplifies things! I'll update the PR. Thank you!
opqdonut
approved these changes
Jan 9, 2025
|
Thanks once again! Released as 0.6.11! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The case addressed in this PR is the following:
mapof some functionfunction-with-logson some range).function-with-logsdoes some logging (either withprns or withclojure.tools.logging)ednoutput is mixed with the output of the logging in lazy sequence.This can be easily avoided if all such responses are realised with a
doall, so this pull request might not be a case at all. Forgetting to realise the sequences can, however, result in hard to spot errors.The solution is not optimal, since it essentially replicates the functionality of
prandpr-onfromclojure.core. Perhaps it should also include some tests fromclojure.coreto ensure that the function remains consistent withpr-str.Commits: