Changes and feedback on tutorial #23
Conversation
| @@ -294,7 +295,7 @@ local_fraction_naming_template_str = 'sec<n>_fraction' | |||
|
|
|||
| In Mu et al. (2022), three GNFR sectors were downscaled including traffic, residential heating and shipping. Denby et al. (2024) extended this list to include aviation and off road emission sources. In this tutorial, we will use the simpler setup by Mu et al. | |||
There was a problem hiding this comment.
It would be nice to link the citations either directly to the publication or to the "references" header. I'm not sure which option would be better.
Also, either a short explanation of what "GNFR" is, or link to an explanation I think would be useful.
| @@ -447,7 +448,7 @@ local_fraction_grid_for_EMEP_additional_grid_interpolation = 2 | |||
|
|
|||
| First we define the type of wind data used for dispersion. | |||
|
|
|||
| ``` | |||
| ```fortran | |||
There was a problem hiding this comment.
It would be helpful with a "copy" button on the code blocks.
There was a problem hiding this comment.
I agree, but I don't think this is possible unfortunately
|
The reference configuration file mentioned in line 126 was missing from the inputdata I received. |
|
I don't really understand what is meant by the comment in line 158. Are we supposed to add actual dates here? |
Some typo fixes and restructuring of text in the uEMEP tutorial. I will add general comments to the file in the PR.
I managed to set up and run the model successfully based on the tutorial (🎉 ), so comments are focused on the text.