Merge Series and Spatial caches #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
intarga
requested changes
May 6, 2024
That's a good idea! I'll make the relevant changes to SpatialTree and do this when I pull the type down into olympian |
intarga
requested changes
May 8, 2024
intarga
approved these changes
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #70.
I left some comments that I guess I'll figure out when I start working on the next parts of the refactor.
@intarga, what do you think about having a
Vec<Location>instead of the threeVec<lat>,Vec<lon>,Vec<elev>?It would simplify the DataCache::new method and the run_test_spatial function, but it also requires changes in SpatialTree, and probably somewhere else I'm not aware of 😅