Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eea all validities #56

Merged
merged 2 commits into from
Jan 7, 2025
Merged

Eea all validities #56

merged 2 commits into from
Jan 7, 2025

Conversation

magnusuMET
Copy link
Collaborator

Previously only observation data where the reported validity was 1 (Valid, https://dd.eionet.europa.eu/vocabulary/aq/observationvalidity) was included. The version included here uses all positive validities, including below detection limit.

@magnusuMET magnusuMET added this to the m2025-01 milestone Jan 7, 2025
@magnusuMET magnusuMET requested a review from heikoklein January 7, 2025 14:20
@heikoklein
Copy link
Member

Just to clarify. Previously means before in this pyaro-reader. This change here aligns the validities to the ones used in the pyaercom EEA-reader for csv-files: https://github.com/metno/pyaerocom/blob/373e4411faee42b1ca6ac640b504d295723c84a2/pyaerocom/io/read_eea_aqerep_base.py#L710

heikoklein
heikoklein approved these changes Jan 7, 2025
View reviewed changes
Copy link
Member

@heikoklein heikoklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@magnusuMET
Copy link
Collaborator Author

This PR aligns with the previous behaviour of the old non-pyaro EEA reader

@heikoklein
Copy link
Member

And All validities means all valid-flags being declared as valid, e.g. > 1, not the validities declared as invalid in https://dd.eionet.europa.eu/vocabulary/aq/observationvalidity (not -1 and -99)

@heikoklein heikoklein merged commit 76acc8e into main-dev Jan 7, 2025
4 checks passed
@magnusuMET magnusuMET deleted the eea-all-validities branch January 7, 2025 14:54
@magnusuMET
Copy link
Collaborator Author

All valids might be a better way of putting it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heikoklein heikoklein heikoklein approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
m2025-01
Development

Successfully merging this pull request may close these issues.
2 participants
@magnusuMET @heikoklein