-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nilupmf #31
Nilupmf #31
Conversation
Needs tests |
Won't work on this until #35 is done, to see if that reader is able to read the same data |
# Conflicts: # setup.cfg
Trying to finish this for the AeroTools release since only linting was going wrong |
@thorbjoernl I just realised test are missing. No need to note that in the review. |
This needs a bit more work than I thought (I thought only linting was missing). But there's no tests and if one supllies a directory the data has to be in certain directory below that. This is not how is should be. |
small comment on the Absorption files: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Reader for the well structured part of the NILU PMF data. Might be redundant if a new EBAS reader is implemented