Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nilupmf #31

Merged
merged 10 commits into from
May 23, 2024
Merged

Nilupmf #31

merged 10 commits into from
May 23, 2024

Conversation

dulte
Copy link
Collaborator

@dulte dulte commented Apr 9, 2024

Reader for the well structured part of the NILU PMF data. Might be redundant if a new EBAS reader is implemented

@dulte dulte added this to the m2024-05 milestone Apr 9, 2024
@dulte dulte added the enhancement New feature or request label Apr 9, 2024
@dulte
Copy link
Collaborator Author

dulte commented Apr 16, 2024

Needs tests

@dulte dulte self-assigned this Apr 16, 2024
@dulte
Copy link
Collaborator Author

dulte commented Apr 16, 2024

Won't work on this until #35 is done, to see if that reader is able to read the same data

Jan Jurgen Griesfeller added 2 commits May 8, 2024 11:24
@jgriesfeller
Copy link
Member

Trying to finish this for the AeroTools release since only linting was going wrong

@jgriesfeller jgriesfeller requested a review from thorbjoernl May 8, 2024 09:26
@jgriesfeller
Copy link
Member

@thorbjoernl I just realised test are missing. No need to note that in the review.

@jgriesfeller
Copy link
Member

This needs a bit more work than I thought (I thought only linting was missing). But there's no tests and if one supllies a directory the data has to be in certain directory below that. This is not how is should be.
Leaving the work to @dulte therefore.

@lewisblake lewisblake modified the milestones: m2024-05, m2024-06 May 8, 2024
@jgriesfeller jgriesfeller assigned jgriesfeller and unassigned dulte May 23, 2024
@jgriesfeller
Copy link
Member

small comment on the Absorption files:
They are not EBAS NASA-AMES compliant (are missing vital metadata like matrix and component) and can therefore not be read with the nilupmfebas reader.
The current implementation depends a bit too much on the files to have a certain format in the header, but since it works for this particular set of files, I kept @dulte 's implementation

@jgriesfeller jgriesfeller marked this pull request as ready for review May 23, 2024 11:45
Copy link
Collaborator

@thorbjoernl thorbjoernl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jgriesfeller jgriesfeller merged commit 95caccb into main-dev May 23, 2024
4 checks passed
@jgriesfeller jgriesfeller deleted the nilupmf branch May 23, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants