Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bugs in 3d collocation and profile processing #973

Merged
merged 11 commits into from
Feb 6, 2024
Merged

Fix bugs in 3d collocation and profile processing #973

merged 11 commits into from
Feb 6, 2024

Conversation

lewisblake
Copy link
Member

No description provided.

@lewisblake lewisblake changed the title Possible needed changes to 3d collocation Needed changes to 3d collocation Feb 2, 2024
@lewisblake lewisblake self-assigned this Feb 5, 2024
@lewisblake lewisblake added this to the m2024-02 milestone Feb 5, 2024
@lewisblake lewisblake changed the title Needed changes to 3d collocation Fix bugs in 3d collocation and profile processing Feb 5, 2024
@lewisblake lewisblake added bug 🐛 Something isn't working CAMS2_82 Issues related to the CAMS2_82 contract labels Feb 5, 2024
jgriesfeller
jgriesfeller approved these changes Feb 6, 2024
View reviewed changes
Copy link
Member

@jgriesfeller jgriesfeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved after correct linting.
The test_dms test has been fixed in my last PR...

@lewisblake lewisblake marked this pull request as ready for review February 6, 2024 10:57
@lewisblake lewisblake merged commit 92f78d3 into main-dev Feb 6, 2024
7 of 19 checks passed
@lewisblake lewisblake deleted the earlinet branch February 23, 2024 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jgriesfeller jgriesfeller jgriesfeller approved these changes

Assignees

@lewisblake lewisblake

Labels
bug 🐛 Something isn't working CAMS2_82 Issues related to the CAMS2_82 contract
Projects
None yet
Milestone
m2024-02
Development

Successfully merging this pull request may close these issues.
2 participants
@lewisblake @jgriesfeller