Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use tmpdir in all tests #1504

Merged
merged 1 commit into from
Feb 6, 2025
Merged

Use tmpdir in all tests #1504

merged 1 commit into from
Feb 6, 2025

Conversation

thorbjoernl
Copy link
Collaborator

@thorbjoernl thorbjoernl commented Feb 6, 2025

Change Summary

Changes the tests which write to pyaerocom root to use a tempdir.

Related issue number

closes #1501

Checklist

  • Start with a draft-PR
  • The PR title is a good summary of the changes
  • PR is set to AeroTools and a tentative milestone
  • Documentation reflects the changes where applicable
  • Tests for the changes exist where applicable
  • Tests pass locally
  • Tests pass on CI
  • At least 1 reviewer is selected
  • Make PR ready to review

@thorbjoernl thorbjoernl added this to the m2025-03 milestone Feb 6, 2025
Copy link

codecov bot commented Feb 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.50%. Comparing base (e478075) to head (8124b16).
Report is 113 commits behind head on main-dev.

Additional details and impacted files
@@            Coverage Diff            @@
##           main-dev    #1504   +/-   ##
=========================================
  Coverage     78.50%   78.50%           
=========================================
  Files           140      140           
  Lines         21285    21285           
=========================================
  Hits          16710    16710           
  Misses         4575     4575           
Flag Coverage Δ
unittests 78.50% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thorbjoernl thorbjoernl marked this pull request as ready for review February 6, 2025 09:29
@lewisblake lewisblake merged commit 66c7d59 into main-dev Feb 6, 2025
8 checks passed
@lewisblake lewisblake deleted the fix-test-output-dirs branch February 6, 2025 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tests clutter up pyaerocom root directory.
2 participants