Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overlays in emep config #1497

Merged
merged 4 commits into from
Feb 6, 2025
Merged

Overlays in emep config #1497

merged 4 commits into from
Feb 6, 2025

Conversation

thorbjoernl
Copy link
Collaborator

@thorbjoernl thorbjoernl commented Jan 29, 2025

Change Summary

https://aeroval-test.met.no/thlun/pages/maps/?project=emep2024-test&experiment=2024-reporting-test-overlays&station=ALL&mapType=overlay

Related issue number

closes #1473

Checklist

  • Start with a draft-PR
  • The PR title is a good summary of the changes
  • PR is set to AeroTools and a tentative milestone
  • Documentation reflects the changes where applicable
  • Tests for the changes exist where applicable
  • Tests pass locally
  • Tests pass on CI
  • At least 1 reviewer is selected
  • Make PR ready to review

@thorbjoernl thorbjoernl added this to the m2025-02 milestone Jan 29, 2025
Copy link

codecov bot commented Jan 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.49%. Comparing base (c972234) to head (3867e4b).
Report is 72 commits behind head on main-dev.

Additional details and impacted files
@@             Coverage Diff              @@
##           main-dev    #1497      +/-   ##
============================================
+ Coverage     78.46%   78.49%   +0.03%     
============================================
  Files           139      140       +1     
  Lines         21124    21299     +175     
============================================
+ Hits          16575    16719     +144     
- Misses         4549     4580      +31     
Flag Coverage Δ
unittests 78.49% <ø> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thorbjoernl thorbjoernl marked this pull request as ready for review February 6, 2025 12:17
@thorbjoernl thorbjoernl marked this pull request as draft February 6, 2025 12:30
@thorbjoernl thorbjoernl marked this pull request as ready for review February 6, 2025 14:11
@lewisblake lewisblake merged commit 0ac8bc2 into main-dev Feb 6, 2025
8 checks passed
@lewisblake lewisblake deleted the overlays-in-emep-config branch February 6, 2025 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

emep reporting-base config should have overlays in addition to contours
2 participants