-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ebase height filter list #1460
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main-dev #1460 +/- ##
============================================
+ Coverage 78.43% 78.49% +0.05%
============================================
Files 137 139 +2
Lines 20963 21090 +127
============================================
+ Hits 16442 16554 +112
- Misses 4521 4536 +15
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Blocked by #1452 |
See also #1463 |
@heikoklein The following station codes do not have altitude data in the ebas index:
|
@thorbjoernl The stations without altitude don't seem to be relevant. The data-files don't have any altitude-information, and the measurements from there is very limited. Just keep them, e.g. don't put them on the ignore list. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looks good. Please remove the outdated comment and merge.
Change Summary
Implements the first part of #1457 which updates the height_ignore_ebas list in the EMEP base config based on relative altitude.
Related issue number
#1457
Checklist