Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ebase height filter list #1460

Merged
merged 3 commits into from
Jan 2, 2025

Conversation

thorbjoernl
Copy link
Collaborator

@thorbjoernl thorbjoernl commented Dec 13, 2024

Change Summary

Implements the first part of #1457 which updates the height_ignore_ebas list in the EMEP base config based on relative altitude.

Related issue number

#1457

Checklist

  • Start with a draft-PR
  • The PR title is a good summary of the changes
  • PR is set to AeroTools and a tentative milestone
  • Documentation reflects the changes where applicable
  • Tests for the changes exist where applicable
  • Tests pass locally
  • Tests pass on CI
  • At least 1 reviewer is selected
  • Make PR ready to review

@thorbjoernl thorbjoernl self-assigned this Dec 13, 2024
@thorbjoernl thorbjoernl added this to the m2025-01 milestone Dec 13, 2024
Copy link

codecov bot commented Dec 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.49%. Comparing base (11c11fb) to head (4426800).
Report is 49 commits behind head on main-dev.

Additional details and impacted files
@@             Coverage Diff              @@
##           main-dev    #1460      +/-   ##
============================================
+ Coverage     78.43%   78.49%   +0.05%     
============================================
  Files           137      139       +2     
  Lines         20963    21090     +127     
============================================
+ Hits          16442    16554     +112     
- Misses         4521     4536      +15     
Flag Coverage Δ
unittests 78.49% <ø> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thorbjoernl
Copy link
Collaborator Author

Blocked by #1452

@magnusuMET
Copy link
Collaborator

See also #1463

@thorbjoernl
Copy link
Collaborator Author

@heikoklein The following station codes do not have altitude data in the ebas index:

BE0002R Oostende
CZ0099R Libus
DK0042R Norduri a Fossum
ES0024U IUMA
GB0017R Heigham Holmes
IE0010U Dublin - University College
IT0011R Longobucco
IT0012R San Lucido
LT0016R Rugsteliskis
NO0726R Grubhei
NO0798R Fagernes
NO0879R Njåskog
NO0901R Åmotsdalen
NO0963R Langavatnet
NO0967R Ramnes
NO0969R NN
NO0990R Frihetsli
NO1006R Sandvik
NO1011R Bokn
RU0021R Zarechensk
SE0004R Ryda Kungsgård
SE0053R Rickleå
SE0080R Djursvallen, Nedre
SE0081R Docksta
SE0082R Granan
SE0083R Grankölen
SE0084R Holmön
SE0085R Jädraås
SE0086R Majstre
SE0087R Pjungserud
SE0088R Sandnäset
SE0089R Staffanstorp
SE0090R Transtrandsberget
SE0091R Tyresta
SE0092R Ytterby
UA0008R Zmeiny Island
US9028R Makah Tribe

@thorbjoernl thorbjoernl marked this pull request as ready for review January 2, 2025 10:13
@heikoklein
Copy link
Member

@thorbjoernl The stations without altitude don't seem to be relevant. The data-files don't have any altitude-information, and the measurements from there is very limited. Just keep them, e.g. don't put them on the ignore list.

@thorbjoernl thorbjoernl requested a review from heikoklein January 2, 2025 10:15
Copy link
Member

@heikoklein heikoklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good. Please remove the outdated comment and merge.

@thorbjoernl thorbjoernl merged commit 5f339f5 into main-dev Jan 2, 2025
8 checks passed
@thorbjoernl thorbjoernl deleted the new-altitude-filter-in-emep-config branch January 2, 2025 10:38
@thorbjoernl thorbjoernl changed the title Use valley-floor altitude filter in emep-config and update ebase height filter list Update ebase height filter list Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants