Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bulkfraction engine for pyaeroval #1458

Merged
merged 40 commits into from
Feb 4, 2025
Merged

Bulkfraction engine for pyaeroval #1458

merged 40 commits into from
Feb 4, 2025

Conversation

dulte
Copy link
Collaborator

@dulte dulte commented Dec 13, 2024

Change Summary

Tries to implement a way of evaluating bulk variables and fraction. Is needed for the "EC for GP revision" project

Checklist

  • Start with a draft-PR
  • The PR title is a good summary of the changes
  • PR is set to AeroTools and a tentative milestone
  • Documentation reflects the changes where applicable
  • Tests for the changes exist where applicable
  • Tests pass locally
  • Tests pass on CI
  • At least 1 reviewer is selected
  • Make PR ready to review

@dulte dulte added the enhancement ✨ New feature or request label Dec 13, 2024
@dulte dulte added this to the m2025-02 milestone Dec 13, 2024
@dulte dulte self-assigned this Dec 13, 2024
Copy link

codecov bot commented Dec 13, 2024

Codecov Report

Attention: Patch coverage is 74.23313% with 42 lines in your changes missing coverage. Please review.

Project coverage is 78.50%. Comparing base (82a50eb) to head (e478075).
Report is 136 commits behind head on main-dev.

Files with missing lines Patch % Lines
pyaerocom/aux_var_helpers.py 10.81% 33 Missing ⚠️
pyaerocom/aeroval/bulkfraction_engine.py 94.23% 6 Missing ⚠️
pyaerocom/aeroval/obsentry.py 80.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           main-dev    #1458      +/-   ##
============================================
+ Coverage     78.49%   78.50%   +0.01%     
============================================
  Files           139      140       +1     
  Lines         21090    21285     +195     
============================================
+ Hits          16554    16710     +156     
- Misses         4536     4575      +39     
Flag Coverage Δ
unittests 78.50% <74.23%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator Author

@dulte dulte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

99f5402 This commit changes alot, and needs to be better tested/looked over before used in ECforGP

@dulte dulte marked this pull request as ready for review January 28, 2025 12:26
@dulte dulte requested a review from magnusuMET January 28, 2025 12:27
Copy link
Collaborator

@magnusuMET magnusuMET left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code is easy to read and the bulk fractioning in an efficient way. Some small nits regarding types which should be easy to fix

pyaerocom/aeroval/bulkfraction_engine.py Outdated Show resolved Hide resolved
pyaerocom/aeroval/bulkfraction_engine.py Outdated Show resolved Hide resolved
pyaerocom/aeroval/bulkfraction_engine.py Outdated Show resolved Hide resolved
pyaerocom/aeroval/coldatatojson_engine.py Outdated Show resolved Hide resolved
pyaerocom/aeroval/obsentry.py Outdated Show resolved Hide resolved
pyaerocom/aeroval/obsentry.py Outdated Show resolved Hide resolved
@magnusuMET magnusuMET merged commit d6dbe0f into main-dev Feb 4, 2025
7 of 8 checks passed
@magnusuMET magnusuMET deleted the bulkfraction branch February 4, 2025 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement ✨ New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants