-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bulkfraction engine for pyaeroval #1458
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main-dev #1458 +/- ##
============================================
+ Coverage 78.49% 78.50% +0.01%
============================================
Files 139 140 +1
Lines 21090 21285 +195
============================================
+ Hits 16554 16710 +156
- Misses 4536 4575 +39
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
99f5402 This commit changes alot, and needs to be better tested/looked over before used in ECforGP
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code is easy to read and the bulk fractioning in an efficient way. Some small nits regarding types which should be easy to fix
Change Summary
Tries to implement a way of evaluating bulk variables and fraction. Is needed for the "EC for GP revision" project
Checklist