Skip to content

Commit

Permalink
Rework comments
Browse files Browse the repository at this point in the history
  • Loading branch information
Lun4m committed Dec 2, 2024
1 parent 5b9ac44 commit 09c6bcf
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 11 deletions.
1 change: 0 additions & 1 deletion migrations/kvalobs/db/base_config.go
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@ type BaseConfig struct {
}

func (config *BaseConfig) ShouldProcessLabel(label *Label) bool {
// (config.Ts == nil || slices.Contains(config.Ts, ts.ID)) ||
return utils.IsEmptyOrContains(config.ParamIds, label.ParamID) &&
// utils.IsEmptyOrContains(config.Stations, label.StationID) &&
utils.IsEmptyOrContains(config.TypeIds, label.TypeID) &&
Expand Down
13 changes: 3 additions & 10 deletions migrations/kvalobs/dump/main.go
Original file line number Diff line number Diff line change
Expand Up @@ -5,16 +5,9 @@ import (
"migrate/utils"
)

// Same timeseries could be in both 'data' and 'text_data' tables
// First of all, why?
// Second, do we care?
// func readDataAndText(label *lard.Label, pool *pgxpool.Pool, config *DumpConfig) Data {
// // Supposed to join text anf number data to single slice
// return nil
// }
//
// TODO: not sure what to do with this one
// func joinTS(first, second []lard.Label)
// TODO: there were some comments in the original script about
// the fact that the same timeseries could be in both
// 'data' and 'text_data'

type Config struct {
db.BaseConfig
Expand Down

0 comments on commit 09c6bcf

Please sign in to comment.