Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue257 rectangle check #258

Merged
merged 3 commits into from
Feb 14, 2025
Merged

Issue257 rectangle check #258

merged 3 commits into from
Feb 14, 2025

Conversation

mortenwh
Copy link
Collaborator

Summary: closes #257

Related issue:

Suggested reviewer(s):

Reviewer checklist:

  • The headers of all files contain a reference to the repository license
  • 100% test coverage of new code - meaning:
    • The overall test coverage increased or remained the same as before
    • Every function is accompanied with a test suite
    • Tests are both positive (testing that the function work as intended with valid data) and negative (testing that the function behaves as expected with invalid data, e.g., that correct exceptions are thrown)
    • Functions with optional arguments have separate tests for all options
  • Examples are supported by doctests
  • All tests are passing
  • All names (e.g., files, classes, functions, variables) are explicit
  • Documentation (as docstrings) is complete and understandable

The checklist is based on the S-ENDA conventions and definition of done (see General Conventions). The above points are not necessarily relevant to all contributions. In that case, please add a short explanation to help the reviewer.

@mortenwh mortenwh requested a review from TAlonglong February 14, 2025 11:39
Copy link
Contributor

@TAlonglong TAlonglong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ser greit ut det

@TAlonglong TAlonglong merged commit 46bd2a5 into main Feb 14, 2025
5 checks passed
@TAlonglong TAlonglong deleted the issue257_rectangle_check branch February 14, 2025 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The rectangle check in dmci.tools.check_mmd is too strict
2 participants