Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove collector registry #242

Merged
merged 1 commit into from
Oct 7, 2024
Merged

remove collector registry #242

merged 1 commit into from
Oct 7, 2024

Conversation

charlienegri
Copy link
Contributor

@charlienegri charlienegri commented Oct 7, 2024

Summary: I think that the extra CollectorRegistry() broke the metrics, the standard flask collector does not work anymore at the moment https://dmci.s-enda-dev.k8s.met.no/metrics, so trying to remove it. testing with a local container still exposes everything so hard to tell if this will fix..

Related issue: #220

Suggested reviewer(s):

Reviewer checklist:

  • The headers of all files contain a reference to the repository license
  • 100% test coverage of new code - meaning:
    • The overall test coverage increased or remained the same as before
    • Every function is accompanied with a test suite
    • Tests are both positive (testing that the function work as intended with valid data) and negative (testing that the function behaves as expected with invalid data, e.g., that correct exceptions are thrown)
    • Functions with optional arguments have separate tests for all options
  • Examples are supported by doctests
  • All tests are passing
  • All names (e.g., files, classes, functions, variables) are explicit
  • Documentation (as docstrings) is complete and understandable

The checklist is based on the S-ENDA conventions and definition of done (see General Conventions). The above points are not necessarily relevant to all contributions. In that case, please add a short explanation to help the reviewer.

@charlienegri charlienegri requested a review from magnarem October 7, 2024 15:05
@charlienegri charlienegri marked this pull request as ready for review October 7, 2024 15:05
Copy link
Contributor

@magnarem magnarem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

@magnarem magnarem merged commit ecdc252 into main Oct 7, 2024
5 checks passed
@magnarem magnarem deleted the custom_metrics_patch branch October 7, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants