Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Dockerfile to project root. #42

Merged
merged 1 commit into from
Sep 12, 2024
Merged

Move Dockerfile to project root. #42

merged 1 commit into from
Sep 12, 2024

Conversation

AkbarTheGreat
Copy link
Contributor

This allows shorter builds for checked out repositories (docker build .) as well as convenient builds off of the git repo (docker build <git url>). See issue #41 for more details.

@AkbarTheGreat
Copy link
Contributor Author

"yep no prob! The dockerfile is referenced in the "release" workflow github action as well and needs adjustment when the file is moved" -- I just saw this comment on the Issue, I'm taking care of it.

@sebhoss
Copy link
Member

sebhoss commented Sep 12, 2024

It's this line -> https://github.com/metio/matrix-alertmanager-receiver/blob/main/.github/workflows/release.yml#L89

This allows shorter builds for checked out repositories (docker build .)
as well as convenient builds off of the git repo (docker build <git
url>).  See issue metio#41 for more details.
@sebhoss sebhoss merged commit fa6438a into metio:main Sep 12, 2024
3 checks passed
@sebhoss
Copy link
Member

sebhoss commented Sep 12, 2024

Lovely, thanks a lot!

spantaleev added a commit to spantaleev/matrix-docker-ansible-deploy that referenced this pull request Sep 18, 2024
venimus pushed a commit to superhero-com/matrix-docker-ansible-deploy that referenced this pull request Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants