Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add applicant tracking API interface #63

Merged
merged 1 commit into from
Jun 12, 2019

Conversation

danhealy
Copy link

@danhealy danhealy commented May 29, 2019

Description

Add Bamboozled::API::ApplicantTracking to implement applicant tracking API.

Documentation for the API: https://www.bamboohr.com/api/documentation/ats.php

  • Add lib/bamboozled/api/applicant_tracking.rb and spec
  • Add fixtures for endpoints used
  • Include reference in lib/bamboozled.rb and lib/bamboozled/base.rb

Related Issue

#62

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Note: Rubocop complains about params option hash for some methods, these should be included in Style/OptionHash exceptions

@splybon
Copy link
Contributor

splybon commented May 29, 2019

Hey @danhealy thanks for this PR, it's looking good! I just wanted to check, are you able to see the travis CI failures?

Looks like it's a rubocop error, and then using #dig on a hash in one of the tests. We run the tests on ruby 2.2 so dig isn't a method yet.

@danhealy
Copy link
Author

@splybon Thanks for taking a look.

In my opinion, the Rubocop error for the Style/OptionHash issue should be ignored in this case as the parameters are being passed to the API as query parameters, and for at least one of the endpoints the options available are numerous. I will add this exception or change it based on your preference.

I hadn't seen the issue with dig -- I will change that.

@splybon
Copy link
Contributor

splybon commented May 29, 2019

@danhealy
Yes I agree with what you said about the rubocop error. Go ahead and disable that with the rubocop disable comment.

@danhealy danhealy force-pushed the feature/ats branch 2 times, most recently from c44a23e to 3eafd0a Compare May 29, 2019 17:38
Copy link
Contributor

@splybon splybon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for this PR, looks great! I finally got around to pulling it locally and testing it. I had 2 comments for it.
If you update it, we can get it merged in, and then there is another PR in that I would like to get merged so we can do a minor release.

spec/fixtures/application.json Show resolved Hide resolved
README.md Show resolved Hide resolved
@chrisman
Copy link
Contributor

chrisman commented Jun 7, 2019

LGTM! Good addition, and a great PR. Thanks @danhealy!

@splybon splybon merged commit 4e0dff4 into method-inc:develop Jun 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants