Fix lost reactivity when using deps #314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We have at least one validation that the approach in this PR fixes the reported issue. @filipenevola Due to the severity of this bug, I don't think we should wait for a test - we should release a new version |
|
Repeating what I said in #306:
|
make-github-pseudonymous-again
added a commit
to infoderm/patients
that referenced
this pull request
Jan 29, 2021
Like 0ce6d70, fixes #166, but without removing the deps arrays. See: - meteor/react-packages#306 - meteor/react-packages#314
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This attempts to fix various lost reactivity reports, as well as some trouble with a particular "Maximum update depth exceeded" error, coming from (possibly) constantly updating
depsinteraction withuseEffect, in two ways:useEffect.reactiveFnalways up to date with the latest render.All tests are passing, but I'd like to see if we can work out a test to confirm the reported error.
#313