-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(subs,deno): advanced filters + context util + replay aware logger #930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael-0acf4
changed the title
feat(sub,deno): advanced filters + context util + replay aware logger
feat(subs,deno): advanced filters + context util + replay aware logger
Nov 28, 2024
zifeo
reviewed
Nov 28, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #930 +/- ##
==========================================
+ Coverage 77.68% 77.75% +0.06%
==========================================
Files 149 152 +3
Lines 18500 18840 +340
Branches 1795 1868 +73
==========================================
+ Hits 14372 14649 +277
- Misses 4105 4167 +62
- Partials 23 24 +1 ☔ View full report in Codecov by Sentry. |
michael-0acf4
requested review from
zifeo,
Natoandro,
Yohe-Am,
j03-dev and
luckasRanarison
December 3, 2024 18:16
zifeo
previously approved these changes
Dec 4, 2024
Yohe-Am
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves MET-720, MET-749 and MET-760.
Basic overview
Given an expression tree, a field can represent either an operator (e.g., and, or, lte, etc.) or a 'special' field (started_at, ended_at, status).
We can now answer queries such as: 'List all failed runs that started between x and y but did not end at z, where the value is not null, or alternatively completed but returned null'
Example:
Migration notes
None