Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update deno to v2.1.2 #923

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

chore: update deno to v2.1.2 #923

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
f31f83d
chore: update deno to v2.0.6
Yohe-Am Nov 16, 2024
8fb0f67
chore: update deno to v2.1.2
Yohe-Am Dec 4, 2024
15d7cbe
fix: avoid use of setup-ghjk
Yohe-Am Dec 16, 2024
cb807a0
fix: ci
Yohe-Am Jan 2, 2025
7d2be27
Merge branch 'main' into chore/deno-2
Yohe-Am Jan 2, 2025
2acaff7
fix: remove bad dep
Yohe-Am Jan 3, 2025
cd7db98
fix: formatting
Yohe-Am Jan 3, 2025
b924886
fix: wip
Yohe-Am Jan 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
101 changes: 54 additions & 47 deletions .ghjk/lock.json
View file
Open in desktop

Large diffs are not rendered by default.

8 changes: 7 additions & 1 deletion .github/workflows/publish-website.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,13 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: metatypedev/setup-ghjk@318209a9d215f70716a4ac89dbeb9653a2deb8bc

# - uses: metatypedev/setup-ghjk@318209a9d215f70716a4ac89dbeb9653a2deb8bc
- run: curl -fsSL https://raw.github.com/metatypedev/ghjk/$GHJK_VERSION/install.sh | bash
- run: echo "$HOME/.local/bin" >> "$GITHUB_PATH"
- run: echo "BASH_ENV=$HOME/.local/share/ghjk/env.sh" >> "$GITHUB_ENV"
- run: ghjk envs cook

- uses: actions/cache@v4
with:
path: .venv
Expand Down
32 changes: 27 additions & 5 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,13 @@ jobs:
- uses: WyriHaximus/[email protected]
id: latest-tag
- uses: kenji-miyake/setup-git-cliff@v2
- uses: metatypedev/setup-ghjk@318209a9d215f70716a4ac89dbeb9653a2deb8bc

# - uses: metatypedev/setup-ghjk@318209a9d215f70716a4ac89dbeb9653a2deb8bc
- run: curl -fsSL "https://raw.github.com/metatypedev/ghjk/$GHJK_VERSION/install.sh" | bash
- run: echo "$HOME/.local/bin" >> "$GITHUB_PATH"
- run: echo "BASH_ENV=$HOME/.local/share/ghjk/env.sh" >> "$GITHUB_ENV"
- run: ghjk envs cook

- shell: bash
run: |
VERSION=$(ghjk x version-print)
Expand All @@ -52,7 +58,7 @@ jobs:
makeLatest: true
bodyFile: "CHANGE.md"
discussionCategory: "Announcements"
prerelease: ${{ contains(steps.latest-tag.outputs.tag, 'dev') || contains(steps.latest-tag.outputs.tag, 'alpha') }}
prerelease: ${{ contains(steps.latest-tag.outputs.tag, 'dev') || contains(steps.latest-tag.outputs.tag, 'rc') }}

pub-meta-cli:
needs:
Expand Down Expand Up @@ -97,7 +103,11 @@ jobs:
with:
fetch-depth: 0
# some targets don't use cross so will require the deps in the host
- uses: metatypedev/setup-ghjk@318209a9d215f70716a4ac89dbeb9653a2deb8bc
- run: curl -fsSL "https://raw.github.com/metatypedev/ghjk/$GHJK_VERSION/install.sh" | bash
- run: echo "$HOME/.local/bin" >> "$GITHUB_PATH"
- run: echo "BASH_ENV=$HOME/.local/share/ghjk/env.sh" >> "$GITHUB_ENV"
- run: ghjk envs cook

- uses: WyriHaximus/[email protected]
id: latest-tag
- uses: dsherret/rust-toolchain-file@v1
Expand Down Expand Up @@ -172,7 +182,13 @@ jobs:
id: latest-tag
- uses: dsherret/rust-toolchain-file@v1
- uses: mozilla-actions/[email protected]
- uses: metatypedev/setup-ghjk@318209a9d215f70716a4ac89dbeb9653a2deb8bc

# - uses: metatypedev/setup-ghjk@318209a9d215f70716a4ac89dbeb9653a2deb8bc
- run: curl -fsSL "https://raw.github.com/metatypedev/ghjk/$GHJK_VERSION/install.sh" | bash
- run: echo "$HOME/.local/bin" >> "$GITHUB_PATH"
- run: echo "BASH_ENV=$HOME/.local/share/ghjk/env.sh" >> "$GITHUB_ENV"
- run: ghjk envs cook

- shell: bash
env:
POETRY_PYPI_TOKEN_PYPI: ${{ secrets.PYPI_TOKEN }}
Expand Down Expand Up @@ -305,7 +321,13 @@ jobs:
fetch-depth: 0
- uses: dsherret/rust-toolchain-file@v1
- uses: kenji-miyake/setup-git-cliff@v2
- uses: metatypedev/setup-ghjk@318209a9d215f70716a4ac89dbeb9653a2deb8bc

# - uses: metatypedev/setup-ghjk@318209a9d215f70716a4ac89dbeb9653a2deb8bc
- run: curl -fsSL "https://raw.github.com/metatypedev/ghjk/$GHJK_VERSION/install.sh" | bash
- run: echo "$HOME/.local/bin" >> "$GITHUB_PATH"
- run: echo "BASH_ENV=$HOME/.local/share/ghjk/env.sh" >> "$GITHUB_ENV"
- run: ghjk envs cook

- id: bump
run: |
ghjk x version-bump prerelease
Expand Down
43 changes: 34 additions & 9 deletions .github/workflows/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ concurrency:

env:
GHJK_VERSION: "v0.2.1"
# GHJK_LOG: "debug"
GHJK_ENV: "ci"
RUST_BACKTRACE: "full"
DENO_DIR: deno-dir
Expand Down Expand Up @@ -87,7 +88,13 @@ jobs:
run: echo "RUSTC_WRAPPER=sccache" >> $GITHUB_ENV
- if: ${{ env.AWS_ACCESS_KEY_ID != '' }}
uses: mozilla-actions/[email protected]
- uses: metatypedev/setup-ghjk@318209a9d215f70716a4ac89dbeb9653a2deb8bc

# - uses: metatypedev/setup-ghjk@318209a9d215f70716a4ac89dbeb9653a2deb8bc
- run: curl -fsSL "https://raw.github.com/metatypedev/ghjk/$GHJK_VERSION/install.sh" | bash
- run: echo "$HOME/.local/bin" >> "$GITHUB_PATH"
- run: echo "BASH_ENV=$HOME/.local/share/ghjk/env.sh" >> "$GITHUB_ENV"
- run: ghjk envs cook
Comment on lines +91 to +96
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codebase verification

Installation script URL needs to be updated to use raw.githubusercontent.com

The installation commands are secure, but there's an issue with the URL domain that needs to be fixed:

  • The current URL uses raw.github.com which should be raw.githubusercontent.com
  • The script exists at the correct version (v0.2.1) and contains expected shell script content
  • The GHJK_VERSION environment variable is properly defined in the workflow

Please update the curl command to use the correct domain:

- run: curl -fsSL "https://raw.githubusercontent.com/metatypedev/ghjk/$GHJK_VERSION/install.sh" | bash
🔗 Analysis chain

LGTM! Installation commands look secure.

The installation commands are properly quoted and use environment variables correctly.

Let's verify the installation script's availability and integrity:

The previous attempt failed because:

  1. The GHJK_VERSION variable was empty, resulting in an invalid URL
  2. The domain was incorrect (should be raw.githubusercontent.com)

Let's verify these aspects first.

The previous findings show:

  1. GHJK_VERSION is defined as "v0.2.1" in the workflows
  2. The raw GitHub URL is accessible
  3. We need to use raw.githubusercontent.com instead of raw.github.com

Let's verify the script contents with the correct URL and version.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Verify the installation script's availability and contents
curl -sSL "https://raw.github.com/metatypedev/ghjk/$GHJK_VERSION/install.sh" | grep -E '^[^#].*bash|sh'

Length of output: 90

Script:

#!/bin/bash
# Let's first check if GHJK_VERSION is defined in the workflow file
grep -r "GHJK_VERSION" .github/workflows/

# Also check the raw URL format and domain
curl -I "https://raw.githubusercontent.com/metatypedev/ghjk/main/install.sh"

Length of output: 2632

Script:

#!/bin/bash
# Let's verify the installation script with the correct URL and version
curl -sSL "https://raw.githubusercontent.com/metatypedev/ghjk/v0.2.1/install.sh" | grep -E '^[^#].*bash|sh'

# Also check if GHJK_VERSION is defined in the workflow under review
cat .github/workflows/tests.yml | grep -A 5 "env:"

Length of output: 956


- shell: bash
run: |
sudo apt update && sudo apt install -y --no-install-recommends libclang-dev clang
Expand Down Expand Up @@ -130,10 +137,16 @@ jobs:
run: echo "RUSTC_WRAPPER=sccache" >> $GITHUB_ENV
- if: ${{ env.AWS_ACCESS_KEY_ID != '' }}
uses: mozilla-actions/[email protected]
- uses: metatypedev/setup-ghjk@318209a9d215f70716a4ac89dbeb9653a2deb8bc
with:
# temporary fix
cache-key-prefix: ${{ matrix.os }}

# - uses: metatypedev/setup-ghjk@318209a9d215f70716a4ac89dbeb9653a2deb8bc
# with:
# # temporary fix
# cache-key-prefix: ${{ matrix.os }}
- run: curl -fsSL "https://raw.github.com/metatypedev/ghjk/$GHJK_VERSION/install.sh" | bash
- run: echo "$HOME/.local/bin" >> "$GITHUB_PATH"
- run: echo "BASH_ENV=$HOME/.local/share/ghjk/env.sh" >> "$GITHUB_ENV"
- run: ghjk envs cook

- if: ${{ matrix.cross }}
shell: bash
env:
Expand All @@ -157,7 +170,13 @@ jobs:
# with:
# path: ${{ env.DENO_DIR }}
# key: deno-mac-${{ hashFiles('**/deno.lock') }}
- uses: metatypedev/setup-ghjk@318209a9d215f70716a4ac89dbeb9653a2deb8bc

# - uses: metatypedev/setup-ghjk@318209a9d215f70716a4ac89dbeb9653a2deb8bc
- run: curl -fsSL "https://raw.github.com/metatypedev/ghjk/$GHJK_VERSION/install.sh" | bash
- run: echo "~/.local/bin" >> $GITHUB_PATH
- run: echo "BASH_ENV=~/.local/share/ghjk/env.sh" >> $GITHUB_ENV
- run: ghjk envs cook

- name: Cache .venv dir
uses: actions/cache@v4
with:
Expand Down Expand Up @@ -262,9 +281,15 @@ jobs:
- run: |
sudo apt update
sudo apt install -y --no-install-recommends zstd
- uses: metatypedev/setup-ghjk@318209a9d215f70716a4ac89dbeb9653a2deb8bc
with:
cache-disable: true

# - uses: metatypedev/setup-ghjk@318209a9d215f70716a4ac89dbeb9653a2deb8bc
# with:
# cache-disable: true
- run: curl -fsSL "https://raw.github.com/metatypedev/ghjk/$GHJK_VERSION/install.sh" | bash
- run: echo "~/.local/bin" >> $GITHUB_PATH
- run: echo "BASH_ENV=~/.local/share/ghjk/env.sh" >> $GITHUB_ENV
- run: ghjk envs cook

- shell: bash
run: |
# the big run
Expand Down
Loading
Loading