Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: cors headers on error #803

Merged
merged 5 commits into from
Aug 5, 2024
Merged

Conversation

j03-dev
Copy link
Contributor

@j03-dev j03-dev commented Aug 1, 2024

Migration notes

...

  • The change comes with new or modified tests
  • Hard-to-understand functions have explanatory comments
  • End-user documentation is updated to reflect the change

Copy link

linear bot commented Aug 1, 2024

@j03-dev j03-dev requested a review from Natoandro August 1, 2024 07:57
Copy link
Contributor

@Natoandro Natoandro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add regression tests?

@Natoandro
Copy link
Contributor

Also, there is a typo on the title :p

@j03-dev j03-dev changed the title feat: cors headerd on error feat: cors headers on error Aug 1, 2024
Copy link

codecov bot commented Aug 1, 2024

Codecov Report

Attention: Patch coverage is 88.88889% with 1 line in your changes missing coverage. Please review.

Project coverage is 69.82%. Comparing base (25d5c24) to head (ac22594).
Report is 1 commits behind head on main.

Files Patch % Lines
typegate/src/services/graphql_service.ts 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #803      +/-   ##
==========================================
- Coverage   69.92%   69.82%   -0.10%     
==========================================
  Files         139      142       +3     
  Lines       16181    16469     +288     
  Branches     1475     1477       +2     
==========================================
+ Hits        11314    11500     +186     
- Misses       4842     4944     +102     
  Partials       25       25              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Natoandro
Copy link
Contributor

LGTM

@j03-dev j03-dev merged commit 2845190 into main Aug 5, 2024
10 of 11 checks passed
@j03-dev j03-dev deleted the feat/met-583-cors-headerd-error branch August 5, 2024 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants