Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: kv runtime #797

Merged
merged 24 commits into from
Aug 13, 2024
Merged

feat: kv runtime #797

merged 24 commits into from
Aug 13, 2024

Conversation

j03-dev
Copy link
Contributor

@j03-dev j03-dev commented Jul 22, 2024 •
edited
Loading

Migration notes

...

  • The change comes with new or modified tests
  • End-user documentation is updated to reflect the change
  • Hard-to-understand functions have explanatory comments

@linear Linear
Copy link

linear bot commented Jul 22, 2024

MET-601 (gate) kv runtime

@codecov Codecov
Copy link

codecov bot commented Jul 22, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 2.77778% with 70 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@a1490e2). Learn more about missing BASE report.

Files Patch % Lines
typegate/src/runtimes/kv.ts 1.40% 69 Missing and 1 partial ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #797   +/-   ##
=======================================
  Coverage        ?   69.40%           
=======================================
  Files           ?      143           
  Lines           ?    16598           
  Branches        ?     1478           
=======================================
  Hits            ?    11520           
  Misses          ?     5052           
  Partials        ?       26

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@j03-dev j03-dev requested a review from Natoandro July 23, 2024 05:52
zifeo
zifeo reviewed Jul 23, 2024
View reviewed changes
typegate/src/runtimes/kv.ts Outdated Show resolved Hide resolved
Natoandro
Natoandro requested changes Jul 23, 2024
View reviewed changes
libs/common/src/typegraph/runtimes/kv.rs Outdated Show resolved Hide resolved
typegate/src/runtimes/kv.ts Outdated Show resolved Hide resolved
typegate/src/typegraph/types.ts Outdated Show resolved Hide resolved
@j03-dev j03-dev force-pushed the feat/met-601-kv-runtime branch from 14d7f1f to 5ba146d Compare July 25, 2024 18:06
@j03-dev j03-dev requested review from zifeo and Natoandro July 30, 2024 08:13
@zifeo
Copy link
Member

zifeo commented Jul 30, 2024

Looks good, definitely missing tests though :)

zifeo
zifeo reviewed Jul 30, 2024
View reviewed changes
typegate/src/runtimes/kv.ts Outdated Show resolved Hide resolved
typegate/src/runtimes/kv.ts Outdated Show resolved Hide resolved
@j03-dev j03-dev force-pushed the feat/met-601-kv-runtime branch 2 times, most recently from 4ba2191 to 6f4b117 Compare August 5, 2024 06:39
Natoandro
Natoandro requested changes Aug 6, 2024
View reviewed changes
Copy link
Contributor

@Natoandro Natoandro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update the docs?

typegate/src/runtimes/kv.ts Outdated Show resolved Hide resolved
typegate/tests/runtimes/kv/kv.py Outdated Show resolved Hide resolved
typegraph/deno/sdk/src/runtimes/kv.ts Outdated Show resolved Hide resolved
typegraph/python/typegraph/runtimes/kv.py Show resolved Hide resolved
typegate/src/runtimes/kv.ts Outdated Show resolved Hide resolved
typegate/tests/runtimes/kv/kv_test.ts Outdated Show resolved Hide resolved
@j03-dev j03-dev force-pushed the feat/met-601-kv-runtime branch 2 times, most recently from a7d4143 to 67f2083 Compare August 7, 2024 19:12
zifeo
zifeo previously approved these changes Aug 7, 2024
View reviewed changes
Natoandro
Natoandro previously approved these changes Aug 8, 2024
View reviewed changes
Copy link
Contributor

@Natoandro Natoandro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

michael-0acf4
michael-0acf4 previously approved these changes Aug 8, 2024
View reviewed changes
@j03-dev j03-dev dismissed stale reviews from michael-0acf4, Natoandro, and zifeo via 79b45cb August 9, 2024 03:07
@j03-dev j03-dev force-pushed the feat/met-601-kv-runtime branch from 67f2083 to 79b45cb Compare August 9, 2024 03:07
@j03-dev j03-dev requested a review from Natoandro August 9, 2024 06:05
@j03-dev j03-dev force-pushed the feat/met-601-kv-runtime branch from ecf5c8a to b21a0da Compare August 11, 2024 16:48
@j03-dev j03-dev requested review from Natoandro and zifeo August 12, 2024 08:12
zifeo
zifeo previously approved these changes Aug 12, 2024
View reviewed changes
website/docs/reference/runtimes/kv/index.mdx Show resolved Hide resolved
zifeo
zifeo previously approved these changes Aug 12, 2024
View reviewed changes
zifeo
zifeo previously approved these changes Aug 12, 2024
View reviewed changes
zifeo
zifeo previously approved these changes Aug 12, 2024
View reviewed changes
@j03-dev j03-dev merged commit 54da279 into main Aug 13, 2024
11 checks passed
@j03-dev j03-dev deleted the feat/met-601-kv-runtime branch August 13, 2024 08:58
Natoandro
Natoandro reviewed Aug 13, 2024
View reviewed changes
typegraph/deno/sdk/src/runtimes/kv.ts
}

#operation(operation: KvMaterializer, effect: Effect) {
const mad_id = runtimes.kvOperation({
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like someone's mad 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Natoandro Natoandro Natoandro left review comments

@michael-0acf4 michael-0acf4 michael-0acf4 approved these changes

@zifeo zifeo zifeo left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@j03-dev @zifeo @michael-0acf4 @Natoandro