Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(tests): improve test suite #27

Merged
merged 8 commits into from
Dec 26, 2023
Merged

feat(tests): improve test suite #27

merged 8 commits into from
Dec 26, 2023

Conversation

Yohe-Am
Copy link
Contributor

@Yohe-Am Yohe-Am commented Dec 21, 2023

Describe your change

  • Tests for the hooks
  • Throw when detecting Errror logs

Motivation and context

#21

Migration notes

No end user changes required.

Checklist

  • The change come with new or modified tests
  • Hard-to-understand functions have explanatory comments
  • End-user documentation is updated to reflect the change

@Yohe-Am Yohe-Am requested a review from zifeo December 23, 2023 02:42
@Yohe-Am
Copy link
Contributor Author

Yohe-Am commented Dec 23, 2023

@zifeo the only thing left here from #21 is the proxy caching improvement. I did some minor experimentation but I think the downloading strategy might change a bit going fwd so I'll tackle the proxy work after that's done. Can we merge this for now?

@Yohe-Am Yohe-Am merged commit c6f46a3 into main Dec 26, 2023
6 checks passed
@Yohe-Am Yohe-Am deleted the fix/#21/improve-tests branch December 26, 2023 09:36
@Yohe-Am Yohe-Am mentioned this pull request Dec 29, 2023
Open
30 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Natoandro Natoandro Natoandro approved these changes

@zifeo zifeo Awaiting requested review from zifeo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Yohe-Am @zifeo @Natoandro