Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ci): macOS support and more fixes #12

Merged
merged 45 commits into from
Dec 15, 2023
Merged

refactor(ci): macOS support and more fixes #12

merged 45 commits into from
Dec 15, 2023

Conversation

Yohe-Am
Copy link
Contributor

@Yohe-Am Yohe-Am commented Dec 11, 2023

Describe your change

This tackles a bunch of minor tasks including:

  • MacOs CI tests
  • Migrate to using # ghjk-hook markers in user shell configs
  • Make installation configurable through env vars
  • Fixing minor bugs
  • Rewrite action in js

Motivation and context

Improvements determined through #495 on metatype.

Migration notes

Lines that load the ghjk hooks will need to be removed from shell configs. The the new installer doesn't recognize them unless they have the mark so manually remove them and install again.

Checklist

  • The change come with new or modified tests
  • Hard-to-understand functions have explanatory comments
  • End-user documentation is updated to reflect the change

@Yohe-Am Yohe-Am marked this pull request as ready for review December 14, 2023 19:12
@Yohe-Am Yohe-Am requested a review from zifeo December 14, 2023 19:21
Copy link
Member

@zifeo zifeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet! Is not there a better way to distribute the dist for the GitHub action? e.g. a different branch of something similar?

@Yohe-Am
Copy link
Contributor Author

Yohe-Am commented Dec 14, 2023

a different branch of something similar?

The docs recommend using a separate repo. Create metatypedev/setup-ghjk?

Also, a bit early but it might be best to maintain the ports themselves in a separate repo. Most of them anyways, some can stay in the core.

Note: just slashed the diff in half but it's still hefty. This isn't minified so we shouldn't see big diffs here going fwd.

@Yohe-Am Yohe-Am merged commit d04c75d into main Dec 15, 2023
7 checks passed
@Yohe-Am Yohe-Am deleted the refactor/ci branch December 15, 2023 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants