Handle undefined and add IN support
#172
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AliusDieMorietur
changed the title
undefined and add IN support
AliusDieMorietur
force-pushed
the
patch
branch
2 times, most recently
from
12f3b76
to
7d9a0ec
Compare
lib/database.js
Outdated
Comment on lines
7
to
17
| const formatWhere = (where) => | ||
| where | ||
| .filter((condition) => !!condition) | ||
| .map((condition) => | ||
| Object.entries(condition).filter((entry) => entry[1] !== undefined) | ||
| ) | ||
| .filter((params) => params.length !== 0) | ||
| .map(Object.fromEntries); |
There was a problem hiding this comment.
We don't need this, at least in this PR, please describe a purpose of this code on separate issue
lib/database.js
Outdated
| conjunction.push(`"${key}" ${operator} $${i++}`); | ||
| args.push(value); | ||
| if (value instanceof Array) { | ||
| const list = value.map(() => `$${i++}`).join(','); |
There was a problem hiding this comment.
test fails at this line because you can't define function inside loop, so please rewrite using external call or nested loop
|
Here is another idea how to const ids = [1, 2, 3];
client.query('SELECT * FROM TableName WHERE id IN $1::int[]', [ids]);Try this as preferred alternative |
AliusDieMorietur
force-pushed
the
patch
branch
2 times, most recently
from
4b85e3d
to
9b87fa7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle these cases:
.select('Table', ['*'], {}) .select('Table', ['*'], { id: undefined }) .select('Table', ['*'], undefined) .select('Table', ['*'], { id: ['1', '2']}).npm t)npm run fmt)