Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Count method #167

Closed
wants to merge 11 commits into from
Closed

Conversation

OleksiiKachan
Copy link
Member

  • tests and linter show no problems (npm t)
  • tests are added/updated for bug fixes and new features
  • code is properly formatted (npm run fmt)
  • description of changes is added in CHANGELOG.md
  • update .d.ts typings

Added Database.count method

Copy link
Member

@tshemsedinov tshemsedinov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use SELECT count(*) FROM... WHERE...

@OleksiiKachan
Copy link
Member Author

@tshemsedinov updated query

lib/database.js Outdated Show resolved Hide resolved
Copy link
Member

@tshemsedinov tshemsedinov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd land this ASAP as two commits:

@tshemsedinov
Copy link
Member

By the way, you have rights to create internal branches in this repo, no need to fork for branching

tshemsedinov pushed a commit that referenced this pull request Aug 9, 2021
Co-authored-by: Timur Shemsedinov <[email protected]>

Closes: #202

PR-URL: #167
tshemsedinov pushed a commit that referenced this pull request Aug 9, 2021
@tshemsedinov
Copy link
Member

Landed in 41a8b21 and 28b1c2f

@tshemsedinov tshemsedinov added the enhancement New feature or request label Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants