Feature/presxml autonum #1247

opoudjis · 2024-11-18T13:39:17Z

Metanorma PR checklist

Breaking changes (list related PRs)
Documentation update required (create task for this)
External dependency introduced (documentation update need)
Gem with native library introduced

hound

Some files could not be reviewed due to errors:

Error: RuboCop found unknown Ruby version 3.4 in `TargetRubyVersion` paramete...

Error: RuboCop found unknown Ruby version 3.4 in `TargetRubyVersion` parameter (in .rubocop.yml).
Supported versions: 2.4, 2.5, 2.6, 2.7, 3.0

hound

Some files could not be reviewed due to errors:

Error: RuboCop found unknown Ruby version 3.4 in `TargetRubyVersion` paramete...

Error: RuboCop found unknown Ruby version 3.4 in `TargetRubyVersion` parameter (in .rubocop.yml).
Supported versions: 2.4, 2.5, 2.6, 2.7, 3.0

…odoc#617

hound

Some files could not be reviewed due to errors:

Error: RuboCop found unknown Ruby version 3.4 in `TargetRubyVersion` paramete...

Error: RuboCop found unknown Ruby version 3.4 in `TargetRubyVersion` parameter (in .rubocop.yml).
Supported versions: 2.4, 2.5, 2.6, 2.7, 3.0

hound

Some files could not be reviewed due to errors:

Error: RuboCop found unknown Ruby version 3.4 in `TargetRubyVersion` paramete...

Error: RuboCop found unknown Ruby version 3.4 in `TargetRubyVersion` parameter (in .rubocop.yml).
Supported versions: 2.4, 2.5, 2.6, 2.7, 3.0

hound

Some files could not be reviewed due to errors:

Error: RuboCop found unknown Ruby version 3.4 in `TargetRubyVersion` paramete...

Error: RuboCop found unknown Ruby version 3.4 in `TargetRubyVersion` parameter (in .rubocop.yml).
Supported versions: 2.4, 2.5, 2.6, 2.7, 3.0

hound

Some files could not be reviewed due to errors:

Error: RuboCop found unknown Ruby version 3.4 in `TargetRubyVersion` paramete...

Error: RuboCop found unknown Ruby version 3.4 in `TargetRubyVersion` parameter (in .rubocop.yml).
Supported versions: 2.4, 2.5, 2.6, 2.7, 3.0

hound

Some files could not be reviewed due to errors:

Error: RuboCop found unknown Ruby version 3.4 in `TargetRubyVersion` paramete...

Error: RuboCop found unknown Ruby version 3.4 in `TargetRubyVersion` parameter (in .rubocop.yml).
Supported versions: 2.4, 2.5, 2.6, 2.7, 3.0

hound

Some files could not be reviewed due to errors:

Error: RuboCop found unknown Ruby version 3.4 in `TargetRubyVersion` paramete...

Error: RuboCop found unknown Ruby version 3.4 in `TargetRubyVersion` parameter (in .rubocop.yml).
Supported versions: 2.4, 2.5, 2.6, 2.7, 3.0

hound

Some files could not be reviewed due to errors:

Error: RuboCop found unknown Ruby version 3.4 in `TargetRubyVersion` paramete...

Error: RuboCop found unknown Ruby version 3.4 in `TargetRubyVersion` parameter (in .rubocop.yml).
Supported versions: 2.4, 2.5, 2.6, 2.7, 3.0

hound

Some files could not be reviewed due to errors:

Error: RuboCop found unknown Ruby version 3.4 in `TargetRubyVersion` paramete...

Error: RuboCop found unknown Ruby version 3.4 in `TargetRubyVersion` parameter (in .rubocop.yml).
Supported versions: 2.4, 2.5, 2.6, 2.7, 3.0

hound

Some files could not be reviewed due to errors:

Error: RuboCop found unknown Ruby version 3.4 in `TargetRubyVersion` paramete...

Error: RuboCop found unknown Ruby version 3.4 in `TargetRubyVersion` parameter (in .rubocop.yml).
Supported versions: 2.4, 2.5, 2.6, 2.7, 3.0

hound

Some files could not be reviewed due to errors:

Error: RuboCop found unknown Ruby version 3.4 in `TargetRubyVersion` paramete...

Error: RuboCop found unknown Ruby version 3.4 in `TargetRubyVersion` parameter (in .rubocop.yml).
Supported versions: 2.4, 2.5, 2.6, 2.7, 3.0

hound

Some files could not be reviewed due to errors:

Error: RuboCop found unknown Ruby version 3.4 in `TargetRubyVersion` paramete...

Error: RuboCop found unknown Ruby version 3.4 in `TargetRubyVersion` parameter (in .rubocop.yml).
Supported versions: 2.4, 2.5, 2.6, 2.7, 3.0

… code: metanorma/isodoc#617

hound

Some files could not be reviewed due to errors:

Error: RuboCop found unknown Ruby version 3.4 in `TargetRubyVersion` paramete...

Error: RuboCop found unknown Ruby version 3.4 in `TargetRubyVersion` parameter (in .rubocop.yml).
Supported versions: 2.4, 2.5, 2.6, 2.7, 3.0

hound

Some files could not be reviewed due to errors:

Error: RuboCop found unknown Ruby version 3.4 in `TargetRubyVersion` paramete...

Error: RuboCop found unknown Ruby version 3.4 in `TargetRubyVersion` parameter (in .rubocop.yml).
Supported versions: 2.4, 2.5, 2.6, 2.7, 3.0

hound

Some files could not be reviewed due to errors:

Error: RuboCop found unknown Ruby version 3.4 in `TargetRubyVersion` paramete...

Error: RuboCop found unknown Ruby version 3.4 in `TargetRubyVersion` parameter (in .rubocop.yml).
Supported versions: 2.4, 2.5, 2.6, 2.7, 3.0

hound

Some files could not be reviewed due to errors:

Error: RuboCop found unknown Ruby version 3.4 in `TargetRubyVersion` paramete...

Error: RuboCop found unknown Ruby version 3.4 in `TargetRubyVersion` parameter (in .rubocop.yml).
Supported versions: 2.4, 2.5, 2.6, 2.7, 3.0

…tanorma/isodoc#617

hound

Some files could not be reviewed due to errors:

Error: RuboCop found unknown Ruby version 3.4 in `TargetRubyVersion` paramete...

Error: RuboCop found unknown Ruby version 3.4 in `TargetRubyVersion` parameter (in .rubocop.yml).
Supported versions: 2.4, 2.5, 2.6, 2.7, 3.0

lib/isodoc/iso/presentation_xref.rb

…tanorma/isodoc#617

hound

Some files could not be reviewed due to errors:

Error: RuboCop found unknown Ruby version 3.4 in `TargetRubyVersion` paramete...

Error: RuboCop found unknown Ruby version 3.4 in `TargetRubyVersion` parameter (in .rubocop.yml).
Supported versions: 2.4, 2.5, 2.6, 2.7, 3.0

lib/isodoc/iso/presentation_xref.rb

@@ -74,7 +74,7 @@

      def locality_span_wrap(ret, type)
        type or return ret
-        m = /^(\s*)(?=\S)(.+?)(\s*)$/.match(ret) or return ret
+        m = /\A(\s*)(?=\S)(.+?)(\s*)\Z/m.match(ret) or return ret


hound

Some files could not be reviewed due to errors:

Error: RuboCop found unknown Ruby version 3.4 in `TargetRubyVersion` paramete...

Error: RuboCop found unknown Ruby version 3.4 in `TargetRubyVersion` parameter (in .rubocop.yml).
Supported versions: 2.4, 2.5, 2.6, 2.7, 3.0

…oc#617

hound

Some files could not be reviewed due to errors:

Error: RuboCop found unknown Ruby version 3.4 in `TargetRubyVersion` paramete...

Error: RuboCop found unknown Ruby version 3.4 in `TargetRubyVersion` parameter (in .rubocop.yml).
Supported versions: 2.4, 2.5, 2.6, 2.7, 3.0

hound

Some files could not be reviewed due to errors:

Error: RuboCop found unknown Ruby version 3.4 in `TargetRubyVersion` paramete...

Error: RuboCop found unknown Ruby version 3.4 in `TargetRubyVersion` parameter (in .rubocop.yml).
Supported versions: 2.4, 2.5, 2.6, 2.7, 3.0

hound · 2024-12-01T09:01:53Z

lib/isodoc/iso/html/isodoc.scss

@@ -1307,7 +1307,7 @@ div.Note table.dl  {
  margin-left: 1.0cm;
 }

-span.note_label, span.example_label, td.example_label, td.note_label
+span.note_label, span.example_label, td.example_label, td.note_label, span.termnote_label, td.termnote_label


Avoid qualifying class selectors with an element.
Each selector in a comma sequence should be on its own single line
Selector example_label should be written in lowercase with hyphens
Selector note_label should be written in lowercase with hyphens
Selector termnote_label should be written in lowercase with hyphens

hound

Some files could not be reviewed due to errors:

Error: RuboCop found unknown Ruby version 3.4 in `TargetRubyVersion` paramete...

Error: RuboCop found unknown Ruby version 3.4 in `TargetRubyVersion` parameter (in .rubocop.yml).
Supported versions: 2.4, 2.5, 2.6, 2.7, 3.0

hound

Some files could not be reviewed due to errors:

Error: RuboCop found unknown Ruby version 3.4 in `TargetRubyVersion` paramete...

Error: RuboCop found unknown Ruby version 3.4 in `TargetRubyVersion` parameter (in .rubocop.yml).
Supported versions: 2.4, 2.5, 2.6, 2.7, 3.0

hound

Some files could not be reviewed due to errors:

Error: RuboCop found unknown Ruby version 3.4 in `TargetRubyVersion` paramete...

Error: RuboCop found unknown Ruby version 3.4 in `TargetRubyVersion` parameter (in .rubocop.yml).
Supported versions: 2.4, 2.5, 2.6, 2.7, 3.0

hound

Some files could not be reviewed due to errors:

Error: RuboCop found unknown Ruby version 3.4 in `TargetRubyVersion` paramete...

Error: RuboCop found unknown Ruby version 3.4 in `TargetRubyVersion` parameter (in .rubocop.yml).
Supported versions: 2.4, 2.5, 2.6, 2.7, 3.0

hound

Some files could not be reviewed due to errors:

Error: RuboCop found unknown Ruby version 3.4 in `TargetRubyVersion` paramete...

Error: RuboCop found unknown Ruby version 3.4 in `TargetRubyVersion` parameter (in .rubocop.yml).
Supported versions: 2.4, 2.5, 2.6, 2.7, 3.0

hound

Some files could not be reviewed due to errors:

Error: RuboCop found unknown Ruby version 3.4 in `TargetRubyVersion` paramete...

Error: RuboCop found unknown Ruby version 3.4 in `TargetRubyVersion` parameter (in .rubocop.yml).
Supported versions: 2.4, 2.5, 2.6, 2.7, 3.0

opoudjis added 2 commits November 17, 2024 22:13

https://github.com/metanorma/isodoc/issues/617

ad158d8

Presentation XML caption refactor: metanorma/isodoc#617

93d44d5

opoudjis self-assigned this Nov 18, 2024

hound bot reviewed Nov 18, 2024

View reviewed changes

Presentation XML caption refactor: metanorma/isodoc#617

3f72f8f

hound bot reviewed Nov 18, 2024

View reviewed changes

modspec update for Presentation XML caption refactoring: metanorma/is…

089296a

…odoc#617

hound bot reviewed Nov 19, 2024

View reviewed changes

Presentation XML caption refactor: metanorma/isodoc#617

0ba54da

hound bot reviewed Nov 20, 2024

View reviewed changes

refactor figure captioning: metanorma/isodoc#617

390bee2

hound bot reviewed Nov 20, 2024

View reviewed changes

refactor examples rendering: metanorma/isodoc#617

0d6d185

hound bot reviewed Nov 20, 2024

View reviewed changes

Presentation XML caption refactor: metanorma/isodoc#617

32ed90d

hound bot reviewed Nov 20, 2024

View reviewed changes

Presentation XML caption refactor: metanorma/isodoc#617

46f58d4

hound bot reviewed Nov 20, 2024

View reviewed changes

Presentation XML caption refactor: metanorma/isodoc#617

9ac412c

hound bot reviewed Nov 20, 2024

View reviewed changes

Presentation XML caption refactor: metanorma/isodoc#617

f857799

hound bot reviewed Nov 20, 2024

View reviewed changes

Presentation XML caption refactor: metanorma/isodoc#617

f09d5a7

hound bot reviewed Nov 21, 2024

View reviewed changes

Presentation XML caption refactor: metanorma/isodoc#617

cba8305

hound bot reviewed Nov 21, 2024

View reviewed changes

mark up annex obligation in title: metanorma/isodoc#617

7605499

hound bot reviewed Nov 21, 2024

View reviewed changes

insert spacing delimiter for note in fmt-name, to simplify downstream…

060fa7f

… code: metanorma/isodoc#617

hound bot reviewed Nov 21, 2024

View reviewed changes

hound bot reviewed Nov 30, 2024

View reviewed changes

https://github.com/metanorma/isodoc/issues/617

fee2fab

hound bot reviewed Nov 30, 2024

View reviewed changes

configurable figure + subfigure label: metanorma/isodoc#617

84edaae

hound bot reviewed Nov 30, 2024

View reviewed changes

cope with multiline xrefs for span annotation with ISO class name: me…

9ec4efd

…tanorma/isodoc#617

hound bot reviewed Nov 30, 2024

View reviewed changes

github-advanced-security bot found potential problems Nov 30, 2024

View reviewed changes

lib/isodoc/iso/presentation_xref.rb Fixed Show fixed Hide fixed

cope with multiline xrefs for span annotation with ISO class name: me…

e66c86b

…tanorma/isodoc#617

hound bot reviewed Nov 30, 2024

View reviewed changes

github-advanced-security bot found potential problems Nov 30, 2024

View reviewed changes

https://github.com/metanorma/isodoc/issues/617

92ebcf8

hound bot reviewed Nov 30, 2024

View reviewed changes

inherit container status of parent in subfigure xrefs: metanorma/isod…

c9648b3

…oc#617

hound bot reviewed Nov 30, 2024

View reviewed changes

https://github.com/metanorma/isodoc/issues/617

cedacae

hound bot reviewed Dec 1, 2024

View reviewed changes

rspec

25a3d38

hound bot reviewed Dec 1, 2024

View reviewed changes

https://github.com/metanorma/isodoc/issues/617

11725f2

hound bot reviewed Dec 3, 2024

View reviewed changes

rspec

53c23e4

hound bot reviewed Dec 4, 2024

View reviewed changes

grammar

f2251e1

hound bot reviewed Dec 8, 2024

View reviewed changes

gemfile

74b0fc9

hound bot reviewed Dec 8, 2024

View reviewed changes

rspec

ba0e0a4

hound bot reviewed Dec 8, 2024

View reviewed changes

opoudjis merged commit 61f947d into main Dec 8, 2024
18 of 22 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature/presxml autonum #1247

Feature/presxml autonum #1247

opoudjis commented Nov 18, 2024

hound bot left a comment

hound bot left a comment

hound bot left a comment

hound bot left a comment

hound bot left a comment

hound bot left a comment

hound bot left a comment

hound bot left a comment

hound bot left a comment

hound bot left a comment

hound bot left a comment

hound bot left a comment

hound bot left a comment

hound bot left a comment

hound bot left a comment

hound bot left a comment

hound bot left a comment

hound bot left a comment

hound bot left a comment

hound bot left a comment

hound bot left a comment

hound bot left a comment

hound bot Dec 1, 2024

hound bot left a comment

hound bot left a comment

hound bot left a comment

hound bot left a comment

hound bot left a comment

hound bot left a comment

Feature/presxml autonum #1247

Feature/presxml autonum #1247

Conversation

opoudjis commented Nov 18, 2024

Metanorma PR checklist

hound bot left a comment

Choose a reason for hiding this comment

hound bot left a comment

Choose a reason for hiding this comment

hound bot left a comment

Choose a reason for hiding this comment

hound bot left a comment

Choose a reason for hiding this comment

hound bot left a comment

Choose a reason for hiding this comment

hound bot left a comment

Choose a reason for hiding this comment

hound bot left a comment

Choose a reason for hiding this comment

hound bot left a comment

Choose a reason for hiding this comment

hound bot left a comment

Choose a reason for hiding this comment

hound bot left a comment

Choose a reason for hiding this comment

hound bot left a comment

Choose a reason for hiding this comment

hound bot left a comment

Choose a reason for hiding this comment

hound bot left a comment

Choose a reason for hiding this comment

hound bot left a comment

Choose a reason for hiding this comment

hound bot left a comment

Choose a reason for hiding this comment

hound bot left a comment

Choose a reason for hiding this comment

hound bot left a comment

Choose a reason for hiding this comment

hound bot left a comment

Choose a reason for hiding this comment

hound bot left a comment

Choose a reason for hiding this comment

hound bot left a comment

Choose a reason for hiding this comment

hound bot left a comment

Choose a reason for hiding this comment

hound bot left a comment

Choose a reason for hiding this comment

hound bot Dec 1, 2024

Choose a reason for hiding this comment

hound bot left a comment

Choose a reason for hiding this comment

hound bot left a comment

Choose a reason for hiding this comment

hound bot left a comment

Choose a reason for hiding this comment

hound bot left a comment

Choose a reason for hiding this comment

hound bot left a comment

Choose a reason for hiding this comment

hound bot left a comment

Choose a reason for hiding this comment