Remove the port from the peer metrics label #206
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is this a BUG FIX or a FEATURE ?:
/kind bug
What this PR does / why we need it:
For each VRF we can have only one neighbor for a given address, which makes the port irrelevant.
Additionally, now that frr-k8s can accept connections too, the port can either be the one used on our side to establish the connection, or the source port in case we are accepting a bgp connection. This makes the metric labels non predictable and hard to monitor.
Because of this, here we remove the port from the label.
Special notes for your reviewer:
Release note: