Make the frr generated files compatible with 8.0+ #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karampok
approved these changes
Jul 11, 2024
| @@ -13,12 +13,13 @@ | |||
| echo-mode | |||
| {{end -}} | |||
| {{ if .profile.EchoInterval -}} | |||
| echo-interval {{.profile.EchoInterval}} | |||
| echo transmit-interval {{.profile.EchoInterval}} | |||
| echo receive-interval {{.profile.EchoInterval}} | |||
There was a problem hiding this comment.
This should ideally be different commit?
There was a problem hiding this comment.
nope, it's actually the core of the commit "make the generated files compatible to 8.0+".
From 8.0 frr format has separate echo-intervals, to the point that frr 9+ is throwing an error when deleting echo-interval (the ci failure I got in metallb).
Let me modify the description of the commit to make it clearer.
FRR 8 preferred format for bfd echo-intervals is with separate transmit / receive timers. FRR 9.1 actually reports an error when deleting the echo interval stanza. Here we: - generate an frr 8.0+ compatible frr configuration file - declare the format of the configuration file to be 8.0 compatible Signed-off-by: Federico Paolinelli <[email protected]>
karampok
approved these changes
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is this a BUG FIX or a FEATURE ?:
What this PR does / why we need it:
FRR 8 preferred format for bfd echo-intervals is with separate transmit
/ receive timers. FRR 9.1 actually reports an error when deleting the
echo interval stanza.
Here we:
Special notes for your reviewer:
Release note: