Fix: initial download failure was stopping extension setup (#169)

* Move download at startup to the background * Changelog
metalbear-co · Feb 5, 2025 · c1d8dcc · c1d8dcc
1 parent e8c40e7
commit c1d8dcc
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/changelog.d/163.fixed.md b/changelog.d/163.fixed.md
@@ -0,0 +1 @@
+mirrord now correctly displays status bar, even if initial download of the mirrord binary fails.
diff --git a/src/extension.ts b/src/extension.ts
@@ -14,8 +14,9 @@ export async function activate(context: vscode.ExtensionContext) {
 	context.workspaceState.update('enabled', enabled);
 	vscode.debug.registerDebugConfigurationProvider('*', new ConfigurationProvider(), 2);
 
-	// start mirrord binary updates, so that we avoid downloading mid session
-	await getMirrordBinary(true);
+	// Start mirrord binary update, so that we avoid downloading mid session.
+	// Do not `await` here. Let this happen in the background.
+	getMirrordBinary(true);
 
 	new MirrordStatus(vscode.window.createStatusBarItem(vscode.StatusBarAlignment.Left, 0))
 		.register()
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		mirrord now correctly displays status bar, even if initial download of the mirrord binary fails.