use ufei default instead of bios

Apart from recent potential issues related to using bios, uefi
default makes makes more sense in general as for a long time
all enterprise hardware is either using uefi or secure-uefi.

This commit:
  - switched the default libvirt boot loader firmware from bios
    to the more modern uefi

config_example.sh

@@ -118,7 +118,7 @@
 #
 # Set libvirt firmware and BMC bootMode
 # Choose "legacy" (bios), "UEFI", or "UEFISecureBoot"
-# Defaults to legacy for ipv4, UEFI for ipv6
+# Defaults to uefi
 # export BOOT_MODE="UEFI"
 
 # Select the Cluster API provider Metal3 version

lib/common.sh

@@ -31,6 +31,7 @@ fi
 source "${CONFIG}"
 
 # Set variables
+export BOOT_MODE="${BOOT_MODE:-UEFI}"
 export MARIADB_HOST="mariaDB"
 export MARIADB_HOST_IP="127.0.0.1"
 # Additional DNS

lib/network.sh

@@ -46,7 +46,6 @@ if [[ "${BARE_METAL_PROVISIONER_SUBNET_IPV6_ONLY}" == "true" ]]; then
   export BOOT_MODE="${BOOT_MODE:-UEFI}"
   export BARE_METAL_PROVISIONER_NETWORK="${BARE_METAL_PROVISIONER_NETWORK:-fd2e:6f44:5dd8:b856::/64}"
 else
-  export BOOT_MODE="${BOOT_MODE:-legacy}"
   export BARE_METAL_PROVISIONER_NETWORK="${BARE_METAL_PROVISIONER_NETWORK:-172.22.0.0/24}"
 fi
 

vars.md

@@ -30,7 +30,7 @@ assured that they are persisted.
 | BMO_ROLLOUT_WAIT | Number of minutes(Until max 10m that is the default value of deployment.spec.progressDeadlineSeconds) to wait for BMO rollout | | 5 |
 | BMC_DRIVER | Set the BMC driver | "ipmi", "redfish", "redfish-virtualmedia" | "mixed" |
 | BMORELEASEBRANCH | BMO Release branch | "main", "release-0.4" | Set via jjb for CI, for local dev it gets default value based on CAPM3 branch |
-| BOOT_MODE  | Set libvirt firmware and BMH bootMode | "legacy", "UEFI", "UEFISecureBoot" | "legacy" |
+| BOOT_MODE  | Set libvirt firmware and BMH bootMode | "legacy", "UEFI", "UEFISecureBoot" | "UEFI" |
 | IMAGE_OS | OS of the image to boot the nodes from, overriden by IMAGE\_\* if set | "centos", "cirros", "FCOS", "ubuntu", "flatcar" | "centos" |
 | IMAGE_NAME | Image for target hosts deployment | | "CENTOS_9_NODE_IMAGE_K8S_${KUBERNETES_VERSION}.qcow2" |
 | IMAGE_LOCATION | Location of the image to download | | https://artifactory.nordix.org/artifactory/metal3/images/${KUBERNETES_VERSION} |

vm-setup/roles/libvirt/defaults/main.yml

@@ -15,7 +15,7 @@ libvirt_diskbus: scsi
 libvirt_cdrombus: sata
 libvirt_arch: x86_64
 libvirt_cpu_mode: host-model
-libvirt_firmware: bios
+libvirt_firmware: uefi
 libvirt_secure_boot: false
 
 # Where to log serial console output