FS-1783: Relax errors for missing component status #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DoctorVin
requested changes
Nov 11, 2024
| if err != nil { | ||
| // Relax error | ||
|
|
||
| zap.L().With( |
There was a problem hiding this comment.
You should include the error here as zap.Error(err) and then Warn() with something like "retrieving status versioned attribute"
Also, return the component without a Status field, so we have as much data in the response as we have in the database for this component.
| @@ -121,7 +122,8 @@ func composeRecords(ctx context.Context, exec boil.ContextExecutor, cmp *rivets. | |||
| } | |||
|
|
|||
| func retrieveComponentAttributes(ctx context.Context, exec boil.ContextExecutor, | |||
| componentID, namespace string) (*rivets.ComponentAttributes, error) { | |||
| componentID, namespace string, | |||
| ) (*rivets.ComponentAttributes, error) { | |||
There was a problem hiding this comment.
please don't break up these lines like this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR logs errors for missing component's status instead of erroring out.