tests: fix intermittent test failures with NATS server

The tests would fail intermittently locally and in the CI
because of the NATS server store directory being the same
across various packages. This sets up a temp store directory that
is cleaned up by the testing package for us.

--- FAIL: TestCreateReadUpdate (0.00s)
    nats_test.go:116:
        	Error Trace:	/home/runner/work/conditionorc/conditionorc/internal/store/nats_test.go:116
        	Error:      	Received unexpected error:
        	            	nats: error opening msg block file ["/tmp/nats/jetstream/$G/streams/KV_active-conditions/msgs/1.blk"]: open /tmp/nats/jetstream/$G/streams/KV_active-conditions/msgs/1.blk: no such file or directory
        	Test:       	TestCreateReadUpdate
--- FAIL: TestMultipleConditionUpdate (0.00s)
    --- FAIL: TestMultipleConditionUpdate/create_multiple_sanity_checks (0.00s)
        nats_test.go:175:
            	Error Trace:	/home/runner/work/conditionorc/conditionorc/internal/store/nats_test.go:175
            	Error:      	Received unexpected error:
            	            	nats: error opening msg block file ["/tmp/nats/jetstream/$G/streams/KV_active-conditions/msgs/1.blk"]: open /tmp/nats/jetstream/$G/streams/KV_active-conditions/msgs/1.blk: no such file or directory

internal/orchestrator/updates_test.go

@@ -44,10 +44,14 @@ func init() {
 	logrus.SetFormatter(&logrus.JSONFormatter{})
 }
 
-func startJetStreamServer() *server.Server {
+func startJetStreamServer(t *testing.T) *server.Server {
+	t.Helper()
+
 	opts := srvtest.DefaultTestOptions
 	opts.Port = -1
 	opts.JetStream = true
+	opts.StoreDir = t.TempDir()
+
 	return srvtest.RunServer(&opts)
 }
 
@@ -63,26 +67,19 @@ func jetStreamContext(s *server.Server) (*nats.Conn, nats.JetStreamContext) {
 	return nc, js
 }
 
-func shutdownJetStream(s *server.Server) {
-	var sd string
-	if config := s.JetStreamConfig(); config != nil {
-		sd = config.StoreDir
-	}
+func shutdownJetStream(t *testing.T, s *server.Server) {
+	t.Helper()
 	s.Shutdown()
-	if sd != "" {
-		if err := os.RemoveAll(sd); err != nil {
-			logger.Fatalf("Unable to remove storage %q: %v", sd, err)
-		}
-	}
 	s.WaitForShutdown()
 }
 
 // let's pretend we're a conditioon-orchestrator app and do some one-time setup
 func TestMain(m *testing.M) {
 	logger = logrus.New()
 
-	srv := startJetStreamServer()
-	defer shutdownJetStream(srv)
+	t := &testing.T{}
+	srv := startJetStreamServer(t)
+	defer shutdownJetStream(t, srv)
 	nc, js = jetStreamContext(srv) // nc is closed on evJS.Close(), js needs no cleanup
 	evJS = events.NewJetstreamFromConn(nc)
 	defer evJS.Close()

internal/status/kv_test.go

@@ -25,6 +25,8 @@ func startJetStreamServer(t *testing.T) *server.Server {
 	opts := srvtest.DefaultTestOptions
 	opts.Port = -1
 	opts.JetStream = true
+	opts.StoreDir = t.TempDir()
+
 	return srvtest.RunServer(&opts)
 }
 

internal/store/nats_test.go

@@ -30,10 +30,14 @@ func init() {
 	logrus.SetFormatter(&logrus.JSONFormatter{})
 }
 
-func startJetStreamServer() *server.Server {
+func startJetStreamServer(t *testing.T) *server.Server {
+	t.Helper()
+
 	opts := srvtest.DefaultTestOptions
 	opts.Port = -1
 	opts.JetStream = true
+	opts.StoreDir = t.TempDir()
+
 	return srvtest.RunServer(&opts)
 }
 
@@ -49,26 +53,19 @@ func jetStreamContext(s *server.Server) (*nats.Conn, nats.JetStreamContext) {
 	return nc, js
 }
 
-func shutdownJetStream(s *server.Server) {
-	var sd string
-	if config := s.JetStreamConfig(); config != nil {
-		sd = config.StoreDir
-	}
+func shutdownJetStream(t *testing.T, s *server.Server) {
+	t.Helper()
 	s.Shutdown()
-	if sd != "" {
-		if err := os.RemoveAll(sd); err != nil {
-			logger.Fatalf("Unable to remove storage %q: %v", sd, err)
-		}
-	}
 	s.WaitForShutdown()
 }
 
 // do some one-time setup
 func TestMain(m *testing.M) {
 	logger = logrus.New()
 
-	srv := startJetStreamServer()
-	defer shutdownJetStream(srv)
+	t := &testing.T{}
+	srv := startJetStreamServer(t)
+	defer shutdownJetStream(t, srv)
 	nc, js = jetStreamContext(srv) // nc is closed on evJS.Close(), js needs no cleanup
 	evJS = events.NewJetstreamFromConn(nc)
 	defer evJS.Close()