Avoid starvation of NSQ event processing #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ackoff is exponential in nsq by default) and increase concurrency by processing at most two events at a time
majst01
reviewed
Jul 9, 2024
There was a problem hiding this comment.
Looks sane to me, still do not understand how this situation can occur. This type of error wasn't seen in any of our production environments up til now.
Downside is that the message will be dropped and not send again because metal-api does not reconcile the desired state.
Gerrit91
reviewed
Jul 10, 2024
Merged
|
Tried this out now and simulated broken IPMI connection by shutting the mgmtspine connection on one mgmt-server. Concurrency definitely works now. It's still not very fast because the timeouts for the IPMI commands are fairly high, but I think it does the job now and should be pretty good. |
Gerrit91
approved these changes
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid starvation of NSQ event processing by configuring max. number of retries of an event (backoff is exponential in nsq by default) and increase concurrency by processing at most two events at a time.