-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configure DNS and NTP in machine allocation #571
Draft
simcod
wants to merge
16
commits into
master
Choose a base branch
from
machine-allocation-with-dns-and-ntp
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+202
−1
Draft
Changes from 8 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
df41e53
Configure DNS servers in machine allocation optionally
simcod 4a18873
Return DNSServers in MachineResponse
simcod ffa8877
Add ntp servers field
simcod 77f0843
NTP and DNS validation
simcod cbf9f21
Regenerate metal-api
simcod fcba3b4
Merge branch 'master' into machine-allocation-with-dns-and-ntp
majst01 139ca1b
Merge remote-tracking branch 'origin' into machine-allocation-with-dn…
simcod fe45192
Use new struct for DNS and NTP servers
simcod 9973d7c
Check for empty ntp servers configuration
simcod f57775b
Add NTP and DNS server field to partition
simcod 7abf175
Add new metal-api JSON
simcod fd58302
Add dns and ntp servers to partition base to include it in response
simcod a8f9111
Add DNS and NTP servers to fix integration test
simcod 21bf0c5
Fix typo
simcod 6a6bf09
Set partition default for machine allocation spec
simcod e82d7d0
Add DNS and NTP servers to partition response
simcod File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should an empty list be allowed, too? In the MEP it says that specifying the NTP servers is optional. And if not provided the distro defaults are used.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, can be totally omitted, but if given len must be between 3 and 5
@simcod this must be fixed obviously