Auditing timescaledb #565
Draft
Auditing timescaledb #565
+92
−34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
majst01
reviewed
Aug 26, 2024
Comment on lines
+291
to
+295
| rootCmd.Flags().String("auditing-meili-url", "http://localhost:7700", "url of the auditing service") | ||
| rootCmd.Flags().String("auditing-meili-api-key", "secret", "api key for the auditing service") | ||
| rootCmd.Flags().String("auditing-meili-index-prefix", "auditing", "auditing index prefix") | ||
| rootCmd.Flags().String("auditing-meili-index-interval", "@daily", "auditing index creation interval, can be one of @hourly|@daily|@monthly") | ||
| rootCmd.Flags().Int64("auditing-meili-keep", 14, "the amount of indexes to keep until cleanup") |
There was a problem hiding this comment.
I would prefer to remove the support for meilisearch completely instead of adding the complexity of supporting multiple auditing backends
There was a problem hiding this comment.
Maybe we will have introduce multiple backends though if FI-TS wants to have Splunk connected. But maybe also we want to introduce the buffer service as well, which we were discussing as well.
There was a problem hiding this comment.
in my opinion, metal-api should only have one auditing implementation, if other parties are interested in other auditing backends, then this should be solved at a later layer.
This is why i would like to vote for a dedicated auditing backend which has plug-able backends
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.