Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Satisfy new govet errors #561

Merged
merged 1 commit into from
Aug 14, 2024
Merged

Satisfy new govet errors #561

merged 1 commit into from
Aug 14, 2024

Conversation

majst01
Copy link
Contributor

@majst01 majst01 commented Aug 14, 2024

Without this, these errors are reported:

cmd/metal-api/main.go:960:83: printf: non-constant format string in call to fmt.Errorf (govet)
                err := response.WriteAsJson(httperrors.NewHTTPError(serviceErr.Code, fmt.Errorf(serviceErr.Message)))
                                                                                                ^
cmd/metal-api/internal/service/machine-service_allocation_test.go:229:43: printf: non-constant format string in call to fmt.Errorf (govet)
                return v1.MachineResponse{}, fmt.Errorf(w.Body.String())
                                                        ^
cmd/metal-api/internal/service/machine-service_allocation_test.go:251:43: printf: non-constant format string in call to fmt.Errorf (govet)
                return v1.MachineResponse{}, fmt.Errorf(w.Body.String())

@majst01 majst01 requested a review from a team as a code owner August 14, 2024 06:21
@majst01 majst01 merged commit f0628c1 into master Aug 14, 2024
2 checks passed
@majst01 majst01 deleted the satisfy-new-linter-errors branch August 14, 2024 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants