Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate ipam to use the grpc service #522

Merged
merged 40 commits into from
Jul 3, 2024
Merged

Migrate ipam to use the grpc service #522

merged 40 commits into from
Jul 3, 2024

Conversation

majst01
Copy link
Contributor

@majst01 majst01 commented Apr 30, 2024 •
edited
Loading

With this PR we move from library usage of go-ipam to a dedicated grpc go-ipam service. This removes the direct dependency to the ipam database as well and makes the overall architecture clearer.

TODO:

Replaces #312

@majst01 majst01 requested a review from a team as a code owner April 30, 2024 14:18
@majst01 majst01 requested a review from Gerrit91 April 30, 2024 14:18
majst01 and others added 21 commits May 1, 2024 09:28
@majst01
Fix integration test
843524a
@majst01
Remove useless nil checks
f9ef2a5
@majst01
Merge master
6a7c274
@majst01
Merge branch 'master' into ipam-as-service
f50838f
@majst01
Merge master
f27b62c
@majst01
Merge branch 'ipam-as-service' of https://github.com/metal-stack/meta…
19c4667 
…l-api into ipam-as-service
@majst01
Tidy
e210dc7
@majst01
Tidy
e6c56f2
@majst01
Remove unneeded func
3dece7e
@Gerrit91
Merge branch 'master' into ipam-as-service
6f7d961
@majst01
Check ipam service on startup
2b74dda
@majst01
Version fix
ac52f45
@majst01
Update actions
03df0fa
@majst01
Merge branch 'master' of https://github.com/metal-stack/metal-api int…
292005d 
…o ipam-as-service
@majst01
Updates
207cfec
@majst01
Add ipam to health status
301ac24
@majst01
Merge branch 'master' of https://github.com/metal-stack/metal-api int…
ded94b4 
…o ipam-as-service
@majst01
Merge master
834bd81
@majst01
Pin go-ipam
7694a58
@majst01
Update protobuf
a19cc00
@majst01
merge master
b7d7a2c
Gerrit91
Gerrit91 reviewed Jun 14, 2024
View reviewed changes
Copy link
Contributor

@Gerrit91 Gerrit91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost done.

cmd/metal-api/internal/ipam/ipam.go Show resolved Hide resolved
cmd/metal-api/internal/ipam/ipam.go Outdated Show resolved Hide resolved
cmd/metal-api/internal/ipam/ipam.go Outdated Show resolved Hide resolved
cmd/metal-api/main.go Outdated Show resolved Hide resolved
cmd/metal-api/main.go Outdated Show resolved Hide resolved
@Gerrit91 Gerrit91 merged commit 6028f51 into master Jul 3, 2024
2 checks passed
@Gerrit91 Gerrit91 deleted the ipam-as-service branch July 3, 2024 11:52
@majst01 majst01 mentioned this pull request Jul 5, 2024
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gerrit91 Gerrit91 Gerrit91 approved these changes

@mwennrich mwennrich mwennrich approved these changes

@vknabel vknabel vknabel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@majst01 @mwennrich @vknabel @Gerrit91