Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove vrfshared from network response. #212

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Remove vrfshared from network response. #212

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions cmd/metal-api/internal/service/v1/network.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ type NetworkImmutable struct {
PrivateSuper bool `json:"privatesuper" description:"if set to true, this network will serve as a partition's super network for the internal machine networks,there can only be one privatesuper network per partition"`
Underlay bool `json:"underlay" description:"if set to true, this network can be used for underlay communication"`
Vrf *uint `json:"vrf" description:"the vrf this network is associated with" optional:"true"`
VrfShared *bool `json:"vrfshared" description:"if set to true, given vrf can be used by multiple networks, which is sometimes useful for network partioning (default: false)" optional:"true"`
ParentNetworkID *string `json:"parentnetworkid" description:"the id of the parent network" optional:"true"`
}

Expand All @@ -35,7 +34,8 @@ type NetworkUsage struct {

// NetworkCreateRequest is used to create a new Network.
type NetworkCreateRequest struct {
ID *string `json:"id" description:"the unique ID of this entity, auto-generated if left empty" unique:"true"`
ID *string `json:"id" description:"the unique ID of this entity, auto-generated if left empty" unique:"true"`
VrfShared *bool `json:"vrfshared" description:"if set to true, given vrf can be used by multiple networks, which is sometimes useful for network partioning (default: false)" optional:"true"`
Describable
NetworkBase
NetworkImmutable
Expand Down
8 changes: 0 additions & 8 deletions spec/metal-api.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3169,10 +3169,6 @@
"description": "the vrf this network is associated with",
"format": "integer",
"type": "integer"
},
"vrfshared": {
"description": "if set to true, given vrf can be used by multiple networks, which is sometimes useful for network partioning (default: false)",
"type": "boolean"
}
},
"required": [
Expand Down Expand Up @@ -3267,10 +3263,6 @@
"description": "the vrf this network is associated with",
"format": "integer",
"type": "integer"
},
"vrfshared": {
"description": "if set to true, given vrf can be used by multiple networks, which is sometimes useful for network partioning (default: false)",
"type": "boolean"
}
},
"required": [
Expand Down