Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use go-ipam with ipv6 support #152

Draft
wants to merge 43 commits into
base: master
Choose a base branch
from
Draft

use go-ipam with ipv6 support #152

wants to merge 43 commits into from

Conversation

majst01
Copy link
Contributor

@majst01 majst01 commented Jan 1, 2021

This enables basic ipv6 support from go-ipam
metal-stack/go-ipam#36

gardener/gardener#4453

  • run test in mini-lab, ensure all works as before with ipv4

TODO:

  • availableips and availablesmallestprefixes are always 0 only on ipv6 networks
  • should we allow networks with mixed address families ? E.g. the internet is made out of both. This way we must add a --ipv6 flag to network ip allocate to get a ipv6 address from a mixed af network.

@majst01 majst01 marked this pull request as ready for review January 15, 2021 10:27
@majst01 majst01 marked this pull request as draft January 15, 2021 10:27
@majst01 majst01 requested a review from Gerrit91 January 15, 2021 10:35
Copy link
Contributor

@Gerrit91 Gerrit91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, let's try it in the mini-lab.

if err != nil {
if !metal.IsNotFound(err) {
if checkError(request, response, utils.CurrentFuncName(), err) {
return
}
}
} else {
if checkError(request, response, utils.CurrentFuncName(), fmt.Errorf("partition with id %q already has a private super network", partition.ID)) {
return
existingsuper := nw.Prefixes[0].String()
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check before len(nw.Prefixes)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants