Migrate to buf v2 config format and update deps #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
majst01
commented
Jun 13, 2024
| } | ||
| // Set up a connection to the server. | ||
| conn, err := grpc.DialContext(ctx, address, opts...) | ||
| conn, err := grpc.NewClient(address, opts...) |
There was a problem hiding this comment.
As this is no longer blocking i will add a Version() endpoint for clients to be able to wait until the service is available.
There was a problem hiding this comment.
Maybe we can even add this to health checks of the metal-api then?
There was a problem hiding this comment.
voted against it because the masterdata-api does not start if the database is not working as required.
vknabel
approved these changes
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.