Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated print_recording.py with PrettyTable #160

Closed
wants to merge 1 commit into from

Conversation

moksha-hub
Copy link

ticket.no = [LB-1504]

Add a column header by using PrettyTable.

@amCap1712 amCap1712 requested a review from mayhem December 27, 2024 08:50
@mayhem
Copy link
Member

mayhem commented Jan 10, 2025

Hi!
A few things about this PR:

  1. You should make a feature-branch in your repo for a new PR. Don't commit things to main.
  2. You didn't add the prettytable dependency to pyprojects.toml
  3. Your output looks incorrect:
+----------------+-------------+------+------+
| Recording Name | Artist Name | MBID | Year |
+----------------+-------------+------+------+
+----------------+-------------+------+------+
Face to Face                                                 Daft Punk                                          59038 056e4                     501 2001
+----------------+-------------+------+------+
| Recording Name | Artist Name | MBID | Year |
+----------------+-------------+------+------+
+----------------+-------------+------+------+
Blood Like Lemonade                                          Morcheeba                                          9e7ae 06710                     963 2010
+----------------+-------------+------+------+
| Recording Name | Artist Name | MBID | Year |
+----------------+-------------+------+------+
+----------------+-------------+------+------+
Gabriel                                                      Lamb                                               02a38 0d4bc                    1742 2001

@moksha-hub moksha-hub closed this by deleting the head repository Jan 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants