Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added losslessfuncs plugin #375

Merged
merged 4 commits into from
Mar 18, 2024
Merged

Added losslessfuncs plugin #375

merged 4 commits into from
Mar 18, 2024

Conversation

phw
Copy link
Member

@phw phw commented Mar 18, 2024

This adds two helper functions $is_lossless() and $is_lossy() to help tagging files depending on whether they are in a lossy or lossless format.

The detection is not actually based on the audio codec but uses formats and some heuristics. While not perfect and does the right thing in the majority of cases and it is an essential part of my file naming script for years. The limitation would be a reason for me not to include it in Picard itself, but as a plugin I think it is fine.

The plugin is already in active use by others as well, see the discussions in the forums:

https://community.metabrainz.org/t/categorizing-lossless-music/258530/
https://community.metabrainz.org/t/is-lossless-plugin-no-longer-working-with-m4a/469429

@phw phw requested a review from zas March 18, 2024 14:08
Copy link
Collaborator

@zas zas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@phw phw merged commit e0f3c29 into 2.0 Mar 18, 2024
10 of 11 checks passed
@phw phw deleted the formathelpers branch March 18, 2024 20:20
@phw phw added the new plugin label Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants