MBS-13870: Add filter for recordings unlinked to works #3443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwiencek
approved these changes
Jan 9, 2025
Comment on lines
53
to
54
| { value => 1, label => l('Linked to works') }, | ||
| { value => 2, label => l('Not linked to works') }, |
There was a problem hiding this comment.
I was wondering if we should use "Related to works" instead (the name of the button in the relationship editor is "Add related work," for example), though we are probably inconsistent about that.
There was a problem hiding this comment.
Fair point, made the change.
This allows filtering an artist's recording list by whether the recordings have at least one work related to them, or they have none. This is admittedly mostly useful for editing, but it can be *very* useful for that, allowing users to easily find recordings that still need work relationships - it would make it much easier to improve the discographies of prolific classical performers, such as orchestras and conductors, and probably be of use also for popular music.
reosarevok
added a commit
that referenced
this pull request
Jan 13, 2025
* master: Update POT files using the production database Merge pull request #3447 from reosarevok/MBS-13866 Convert Wikimedia classes to components (#3407) MBS-13897: Display "Account admin" under user types on profile Link to bot docs from user types list Link to beginner docs from user types list MBS-13896: Fix anchor links for editor types Merge pull request #3443 from reosarevok/MBS-13870 Merge pull request #3445 from reosarevok/MBS-13895 MBS-13857: Block unicode Tags block in usernames MBS-13893: Block invisible characters (Hangul, Braille) in usernames MBS-13886: Don't crash on wrong link_type for paged rels (#3434) MBS-13781: Support browsing genres by collection in the API (#3394) Preserve the selected AC filter in more cases Fix untranslatable statistics label Don't force new vote names to be translated twice Clean broken enter_votes code MBS-13770: Allow admins to auto-approve and auto-reject any edit MBS-13770: Add new Admin approval/rejection votes Keep filter when navigating with ArtistIndex footer MBS-11950: Allow filtering VA RGs for artist MBS-8186: Allow filtering unofficial RG list Split and document Data::Alias test MBS-13564: Correctly override primary on alias locale change
reosarevok
added a commit
that referenced
this pull request
Jan 27, 2025
* beta: Translated using Weblate (Albanian) Translated using Weblate (Italian) Translated using Weblate (Finnish) Translated using Weblate (Lithuanian) Update translation files Update POT files using the production database Update POT files using the production database Amend some l_statistics changes Translated using Weblate (Albanian) Translated using Weblate (Polish) Translated using Weblate (Chinese (Simplified Han script)) Translated using Weblate (Italian) Translated using Weblate (Chinese (Traditional Han script)) Update translation files MBS-13770: Don't show admin approval buttons on edit lists (#3449) MBS-13902: Add test for persistent (did:plc) Bluesky links (#3448) MBS-13907: Support Discogs label URLs for events (#3452) MBS-13903: Fix "CDTOC is already attached" error (#3451) Add providePluginConfig for `*l*_mb_server` functions Add missing `*l*_mb_server` function names to .eslintrc.unfixed.yaml Use more standard l_mb_server name Fix "Checking translation domain in statistics code" test Reuse server strings when possible in stats Update POT files using the production database Translated using Weblate (Italian) Merge pull request #3447 from reosarevok/MBS-13866 Add `Form::Role::OptionsTree` Make `Data::LinkType` consume `Data::Role::OptionsTree` MBS-12781: Avoid admin accidentally breaking options trees Ensure all entities have "table" in entities.mjs Convert Wikimedia classes to components (#3407) MBS-13897: Display "Account admin" under user types on profile Link to bot docs from user types list Link to beginner docs from user types list MBS-13896: Fix anchor links for editor types Merge pull request #3443 from reosarevok/MBS-13870 Merge pull request #3445 from reosarevok/MBS-13895 MBS-13857: Block unicode Tags block in usernames MBS-13893: Block invisible characters (Hangul, Braille) in usernames MBS-13886: Don't crash on wrong link_type for paged rels (#3434) MBS-13781: Support browsing genres by collection in the API (#3394) Preserve the selected AC filter in more cases Fix untranslatable statistics label Don't force new vote names to be translated twice Clean broken enter_votes code MBS-13770: Allow admins to auto-approve and auto-reject any edit MBS-13770: Add new Admin approval/rejection votes Keep filter when navigating with ArtistIndex footer MBS-11950: Allow filtering VA RGs for artist MBS-8186: Allow filtering unofficial RG list Split and document Data::Alias test MBS-13564: Correctly override primary on alias locale change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement MBS-13870
Description
This allows filtering an artist's recording list by whether the recordings have at least one work linked to them, or they have none.
This is admittedly mostly useful for editing, but it can be very useful for that, allowing users to easily find recordings that still need work relationships - it would make it much easier to improve the discographies of prolific classical performers, such as orchestras and conductors, and probably be of use also for popular music.
I did consider making it more complicated (to allow filtering by writer of the linked works, for example) but that's a lot more work and I was afraid that it would get crazy and unwieldy anyway for something like the Berliner Philharmoniker (which is the kind of artist where it could theoretically be useful). So for now, this is a simple "has linked works / has no linked works", which I'd love to use to clean stuff up.
Testing
Manually first, and added tests for this to the sprawling
Filteringtest.