Convert Wikimedia classes to components #3407
Open
+104
−85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwiencek
reviewed
Nov 27, 2024
reosarevok
force-pushed
the
wikimedia-components
branch
from
05ccb8f to
bc9ffbf
Compare
This turns the WikipediaExtract file (and the mostly deprecated CommonsImage one) from classes to React components, and moves from jQuery to useCallback/useEffect hooks.
reosarevok
force-pushed
the
wikimedia-components
branch
from
bc9ffbf to
7c31f89
Compare
mwiencek
requested changes
Jan 8, 2025
Comment on lines
+41
to
+48
| const loadCallback: CommonsImageRequestCallbackT = | ||
| React.useCallback((data) => { | ||
| setCommonsImage(data); | ||
| }, [setCommonsImage]); | ||
|
|
||
| React.useEffect(() => { | ||
| if (cachedImage == null) { | ||
| loadCommonsImage(entity, loadCallback); |
There was a problem hiding this comment.
The set function returned from useState is stable, so there's actually no need to wrap it in useCallback. You don't even have to include it in useEffect dependency lists.
Suggested change
| const loadCallback: CommonsImageRequestCallbackT = | |
| React.useCallback((data) => { | |
| setCommonsImage(data); | |
| }, [setCommonsImage]); | |
| React.useEffect(() => { | |
| if (cachedImage == null) { | |
| loadCommonsImage(entity, loadCallback); | |
| React.useEffect(() => { | |
| if (cachedImage == null) { | |
| loadCommonsImage(entity, setCommonsImage); |
| </div> | ||
| ) : null; | ||
| } | ||
| }, [entity, loadCallback]); |
There was a problem hiding this comment.
Suggested change
| }, [entity, loadCallback]); | |
| }, [entity]); |
Comment on lines
+61
to
+64
| const loadCallback: WikipediaExtractRequestCallbackT = | ||
| React.useCallback((data) => { | ||
| setWikipediaExtract(data); | ||
| }, [setWikipediaExtract]); |
There was a problem hiding this comment.
Suggested change
| const loadCallback: WikipediaExtractRequestCallbackT = | |
| React.useCallback((data) => { | |
| setWikipediaExtract(data); | |
| }, [setWikipediaExtract]); |
| }); | ||
| React.useEffect(() => { | ||
| if (cachedWikipediaExtract == null) { | ||
| loadWikipediaExtract(entity, loadCallback); |
There was a problem hiding this comment.
Suggested change
| loadWikipediaExtract(entity, loadCallback); | |
| loadWikipediaExtract(entity, setWikipediaExtract); |
| } | ||
| } | ||
| }, [entity, loadCallback]); |
There was a problem hiding this comment.
Suggested change
| }, [entity, loadCallback]); | |
| }, [entity]); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This turns the
WikipediaExtractfile (and the mostly deprecatedCommonsImageone) from classes to React components, and moves from jQuery touseCallback/useEffecthooks.Testing
Manually, by loading some files with both in a dev setup, such as
/artist/ae0b2424-d4c5-4c54-82ac-fe3be5453270