Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Donation Flair Settings Page #3016

Merged
merged 8 commits into from
Nov 7, 2024

Conversation

anshg1214
Copy link
Member

No description provided.

@MonkeyDo MonkeyDo changed the base branch from master to donation-flairs October 29, 2024 13:50
Copy link
Member

@MonkeyDo MonkeyDo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for setting that up!
Some preliminary comments

frontend/js/src/settings/layout.tsx Outdated Show resolved Hide resolved
frontend/js/src/settings/Settings.tsx Outdated Show resolved Hide resolved
frontend/js/src/settings/Settings.tsx Outdated Show resolved Hide resolved
frontend/js/src/settings/Settings.tsx Outdated Show resolved Hide resolved
frontend/js/src/utils/types.d.ts Outdated Show resolved Hide resolved
@pep8speaks
Copy link

Hello @anshg1214! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 12:131: E501 line too long (138 > 130 characters)

Line 76:5: E303 too many blank lines (2)
Line 100:5: E303 too many blank lines (2)

@anshg1214 anshg1214 force-pushed the ansh/add-donation-flair-settings branch from 07c9d10 to 55b2e9c Compare November 3, 2024 12:31
@MonkeyDo
Copy link
Member

MonkeyDo commented Nov 5, 2024

I guess this is about ready to merge, what do you think?

I've started working on a PR to add some CSS flairs, as you work on the username component (I checked, and it will indeed be required for some of the animations). Then we can tie it all together!

@anshg1214
Copy link
Member Author

Yes, this PR is ready for merge. I'll open a followup PR for adding a username component

@anshg1214 anshg1214 marked this pull request as ready for review November 7, 2024 09:49
Copy link
Member

@MonkeyDo MonkeyDo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MonkeyDo MonkeyDo merged commit 1dca5ff into donation-flairs Nov 7, 2024
2 checks passed
@MonkeyDo MonkeyDo deleted the ansh/add-donation-flair-settings branch November 7, 2024 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants