LB-1647: use anchor links in MissingData pagination #3001
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of using links as buttons and navigating programmatically, preventing opening in new tab for example
anshg1214
requested changes
Oct 20, 2024
after changes in 1cd6f70 a bunch of code is not used anymore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On the Missing Data page, the pagination uses anchor links as buttons and does navigation programmatically.
This prevents opening the next page in new tab, for example.
Instead, use the react-router Link component which renders an anchor link.
See on hover that it is indeed a regular anchor link according tho the browser:
Also opted for disabling prev/next buttons on first/last page respectively, instead of making them invisible which is not required and changes the UI elements for no good reason.