Make reusable scroll container with indicator arrows #2995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Copied styling and functionality for horizontal scroll with arrows to the left and right from the "created for you" page so it can be reused elsewhere
Remove code that has been refactored and use the new component
Can be turned off with an option, on by default. Slowly replaces the dragScroll library also used
anshg1214
requested changes
Oct 10, 2024
instead of some randomly chosen prop name that will be confusing
anshg1214
approved these changes
Oct 10, 2024
This was referenced Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes a scroll container we are currently using on the "created for you" page reusable so we don't have to reimplement it elsewhere.
This follows a discussion on the LB channel regarding the artist page and its album grid, which is not very usable on desktop if you don't have a trackpad.
Preparations for https://tickets.metabrainz.org/browse/LB-1652, we can reuse this new component for said album grid allowing for arrows and styled scrollbar underneath.
In the meantime, in this PR it's only moving current functionality around and improving customizability with some extra options (optional scrollbar, optional drag-to-scroll, both active by default, and custom css class names for targeted styling).
Example with arrows and scrollbar: